Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 623933003: Replacing the OVERRIDE with override and FINAL with final in content/browser/fileapi (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in content/browser/fileapi This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/e1177d0e38056ce91a8ef0fccc5bccd97a5bbb0d Cr-Commit-Position: refs/heads/master@{#298389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -73 lines) Patch
M content/browser/fileapi/blob_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/chrome_blob_storage_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/copy_or_move_file_validator_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/file_system_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/fileapi/file_system_file_stream_reader_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/file_system_operation_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/file_system_operation_runner_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/file_system_url_request_job_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/fileapi/file_writer_delegate_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/local_file_stream_reader_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/local_file_stream_writer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/mock_file_change_observer.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/fileapi/mock_file_update_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/mock_url_request_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/plugin_private_file_system_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/recursive_operation_delegate_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M content/browser/fileapi/transient_file_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/upload_file_system_file_element_reader.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/fileapi/upload_file_system_file_element_reader_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 03:42:11 UTC) #2
Avi (use Gerrit)
Stampity stamp LGTM
6 years, 2 months ago (2014-10-07 03:57:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623933003/1
6 years, 2 months ago (2014-10-07 04:25:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as b7c911ae35a4293055b285f1f6779ece89c0a344
6 years, 2 months ago (2014-10-07 05:54:41 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 05:55:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1177d0e38056ce91a8ef0fccc5bccd97a5bbb0d
Cr-Commit-Position: refs/heads/master@{#298389}

Powered by Google App Engine
This is Rietveld 408576698