[login_manager] Prevent non-children from calling RestartJob

[login_manager] Prevent non-children from calling RestartJob

We were allowing any process to restart chrome, with an arbitrary set
of command-line options.  Disallow this by checking the pid of anyone who
attempts to RestartJob and only allowing the call to succeed if it's issued
by a process managed by session_manager.

BUG=10877
TEST=suite_Smoke; install on device and use dbus-send to attempt to restartjob, and see that it won't work

Change-Id: Ia6586c80c2325f557566d162a15da444dfed72ce

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=102fed0

[Will Drewry, 2011-01-13 17:08:52]

LGTM

We should really just make the API RestartInGuestMode() or something similar.

[Chris Masone, 2011-01-13 18:29:57]

On 2011/01/13 17:08:52, Will Drewry wrote:
> LGTM
> 
> We should really just make the API RestartInGuestMode() or something similar.

The problem is that the chrome-side people require the ability to pass
command-line flags.  They need to just figure out how to enter a Guest session
without restarting the browser.  There's an issue filed for that, maybe we can
get it bumped up in priority.

[Will Drewry, 2011-01-13 18:33:14]

On Thu, Jan 13, 2011 at 12:29 PM,  <cmasone@chromium.org> wrote:
> On 2011/01/13 17:08:52, Will Drewry wrote:
>>
>> LGTM
>
>> We should really just make the API RestartInGuestMode() or something
>> similar.
>
> The problem is that the chrome-side people require the ability to pass
> command-line flags.  They need to just figure out how to enter a Guest
> session
> without restarting the browser.  There's an issue filed for that, maybe we
> can
> get it bumped up in priority.

That or since we pass in the args for Chrome to begin with, we just
also control the Guest mode flags. AFAICT, there is no benefit to
having Chrome control it -- in fact it has lead to some incorrect
flagging since we have to update Chrome in addition to
session_manager.git when we're changing defaults across the system
(e.g., nacl).

But maybe I'm missing some super important point :/
will