LayoutTests/http/tests/geofencing/apis_not_implemented.html - Issue 623813002: Blink side of exposing the service worker registration associated with geofencing API calls.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/geofencing/apis_not_implemented.html

Issue 623813002: Blink side of exposing the service worker registration associated with geofencing API calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: remove NavigatorGeofencing Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/geofencing/geofencing-not-implemented.html ('k') | LayoutTests/http/tests/geofencing/resources/emptyworker.js » ('j') | Source/modules/geofencing/Geofencing.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Tests that all geofencing methods exposed on a service worker registratio n always reject.</title>

	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="../resources/testharness-helpers.js"></script>

	6 <script src="../serviceworker/resources/test-helpers.js"></script>

	7 <script>

	8 var sw_url = 'resources/emptyworker.js';

	9 var sw_scope = '/service-worker-scope' + window.location.pathname;

	10

	11 promise_test(function(test) {

	12 return assert_promise_rejects(

	13 service_worker_unregister_and_register(test, sw_url, sw_scope + '/register ')

	14 .then(function(r) {

	15 return r.geofencing.registerRegion(

	16 new CircularGeofencingRegion({latitude: 37.421999,

	17 longitude: -122.084015}));

	18 }),

	19 'AbortError',

	20 'registerRegion should fail with an AbortError');

	21 }, 'registerRegion should fail');

	22

	23 promise_test(function(test) {

	24 return assert_promise_rejects(

	25 service_worker_unregister_and_register(test, sw_url, sw_scope + '/unregist er')

	26 .then(function(r) {

	27 return r.geofencing.unregisterRegion('');
	jsbell 2014/10/14 17:19:23 nit: 2 more spaces. nit: 2 more spaces. Marijn Kruisselbrink 2014/10/14 18:21:07 Done. Show quoted text On 2014/10/14 17:19:23, jsbell wrote: > nit: 2 more spaces. Done.
	28 }),

	29 'AbortError',

	30 'unregisterRegion should fail with an AbortError');

	31 }, 'unregisterRegion should fail');

	32

	33 promise_test(function(test) {

	34 return assert_promise_rejects(

	35 service_worker_unregister_and_register(test, sw_url, sw_scope + '/getregio ns')

	36 .then(function(r) {

	37 return r.geofencing.getRegisteredRegions();
	michaeln 2014/10/14 01:16:15 indent here doesn't match the indent on line 15, i indent here doesn't match the indent on line 15, i don't know which style is right? jsbell 2014/10/14 17:19:23 Should be 4. 2 from wrapping the contents of `then Show quoted text On 2014/10/14 01:16:15, michaeln wrote: > indent here doesn't match the indent on line 15, i don't know which style is > right? Should be 4. 2 from wrapping the contents of `then()` and 2 more from the `function() {}` (Neither my text editor nor my guts agree, but that's what I've been told. ES6 arrow functions FTW?) Marijn Kruisselbrink 2014/10/14 18:21:07 Done. Show quoted text On 2014/10/14 17:19:23, jsbell wrote: > On 2014/10/14 01:16:15, michaeln wrote: > > indent here doesn't match the indent on line 15, i don't know which style is > > right? > > Should be 4. 2 from wrapping the contents of `then()` and 2 more from the > `function() {}` > > (Neither my text editor nor my guts agree, but that's what I've been told. ES6 > arrow functions FTW?) > Done.
	38 }),

	39 'AbortError',

	40 'getRegisteredRegions should fail with an AbortError');

	41 }, 'getRegisteredRegions should fail');

	42

	43 </script>

OLD	NEW