LayoutTests/http/tests/geofencing/apis_not_implemented.html - Issue 623813002: Blink side of exposing the service worker registration associated with geofencing API calls.

Side by Side Diff: LayoutTests/http/tests/geofencing/apis_not_implemented.html

Issue 623813002: Blink side of exposing the service worker registration associated with geofencing API calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add test Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Basic test for some stuff</title>
	jsbell 2014/10/08 18:51:57 Real title Real title Marijn Kruisselbrink 2014/10/08 23:00:31 Done. Show quoted text On 2014/10/08 18:51:57, jsbell wrote: > Real title Done.
	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="../serviceworker/resources/test-helpers.js"></script>

	6 <script>

	7 // Copied from http/tests/serviceworker/resources/worker-test-harness.js, can be

	8 // removed once this makes it into testharness.js itself.

	9 function promise_test(func, name, properties) {

	10 properties = properties \|\| {};

	11 var test = async_test(name, properties);

	12 Promise.resolve(test.step(func, test, test))

	13 .then(function() { test.done(); })

	14 .catch(test.step_func(function(value) {

	15 throw value;

	16 }));

	17 }

	18

	19 var sw_url = 'resources/emptyworker.js';

	20 var sw_scope = window.location.origin + '/service-worker-scope' +
	jsbell 2014/10/08 18:51:57 Don't need window.location.origin here - the scope Don't need window.location.origin here - the scope will be resolved relative to it automatically. Marijn Kruisselbrink 2014/10/08 23:00:32 Okay, I just copied this from some of the existing Show quoted text On 2014/10/08 18:51:57, jsbell wrote: > Don't need window.location.origin here - the scope will be resolved relative to > it automatically. Okay, I just copied this from some of the existing service worker tests, but I've removed that bit.
	21 window.location.pathname;

	22

	23 promise_test(function(test) {

	24 return service_worker_unregister_and_register(test, sw_url,

	25 sw_scope + '/register')

	26 .then(function(r) {

	27 return r.geofencing.registerRegion(

	28 new CircularGeofencingRegion({latitude: 37.421999,

	29 longitude: -122.084015}))

	30 .then(test.unreached_func('Promise should not have resolved'))

	31 .catch(function() { });
	jsbell 2014/10/08 18:51:56 Assert something about the rejection here, so you Assert something about the rejection here, so you know the registration is failing for the reasons you expect (and not e.g. part of the test throwing due to a typo in the script) Marijn Kruisselbrink 2014/10/08 23:00:32 I now did that by copying even more code from work Show quoted text On 2014/10/08 18:51:56, jsbell wrote: > Assert something about the rejection here, so you know the registration is > failing for the reasons you expect (and not e.g. part of the test throwing due > to a typo in the script) I now did that by copying even more code from worker-test-harness.js into this test... Is there any reason things like promise_test and assert_promise_rejects live in worker-test-harness.js instead of in some file that can actually be included from non worker based tests as well? Any suggestions what file to move these to? jsbell 2014/10/08 23:13:54 Yeah, sorry about that. We'd been hoping to upstre Show quoted text On 2014/10/08 23:00:32, Marijn Kruisselbrink wrote: > On 2014/10/08 18:51:56, jsbell wrote: > > Assert something about the rejection here, so you know the registration is > > failing for the reasons you expect (and not e.g. part of the test throwing due > > to a typo in the script) > I now did that by copying even more code from worker-test-harness.js into this > test... Is there any reason things like promise_test and assert_promise_rejects > live in worker-test-harness.js instead of in some file that can actually be > included from non worker based tests as well? Any suggestions what file to move > these to? Yeah, sorry about that. We'd been hoping to upstream these but the W3C reviewers are being slow and we haven't been pushing. You should coordinate with asanka@ who's been working on cleaning up the tests and owns the upstreaming patch. I completely support factoring some of these helpers out and landing them in e.g. LayoutTests/http/tests/resources/testharness-helpers.js or something. We were just waiting 'til someone else wanted them.
	32 });

	33 }, 'registerRegion should fail');

	34

	35 promise_test(function(test) {

	36 return service_worker_unregister_and_register(test, sw_url,

	37 sw_scope + '/unregister')

	38 .then(function(r) {

	39 return r.geofencing.unregisterRegion("")
	jsbell 2014/10/08 18:51:57 Prefer single quotes: '' Prefer single quotes: '' Marijn Kruisselbrink 2014/10/08 23:00:32 Done. Show quoted text On 2014/10/08 18:51:57, jsbell wrote: > Prefer single quotes: '' Done.
	40 .then(test.unreached_func('Promise should not have resolved'))

	41 .catch(function() { });
	jsbell 2014/10/08 18:51:56 Assert something about the rejection here. Assert something about the rejection here. Marijn Kruisselbrink 2014/10/08 23:00:32 Done. Show quoted text On 2014/10/08 18:51:56, jsbell wrote: > Assert something about the rejection here. Done.
	42 });

	43 }, 'unregisterRegion should fail');

	44

	45 promise_test(function(test) {

	46 return service_worker_unregister_and_register(test, sw_url,

	47 sw_scope + '/getregions')

	48 .then(function(r) {

	49 return r.geofencing.getRegisteredRegions()

	50 .then(test.unreached_func('Promise should not have resolved'))

	51 .catch(function() { });
	jsbell 2014/10/08 18:51:57 Assert something about the rejection here. Assert something about the rejection here. Marijn Kruisselbrink 2014/10/08 23:00:32 Done. Show quoted text On 2014/10/08 18:51:57, jsbell wrote: > Assert something about the rejection here. Done.
	52 });

	53 }, 'getRegisteredRegions should fail');

	54

	55 </script>

OLD	NEW