sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart - Issue 62373009: Field property naming fix - issues 14096, 14806

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

Issue 62373009: Field property naming fix - issues 14096, 14806 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review changes Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/codegen.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

index 882e0aa8493029860a8eb7a452a38e37eff576a6..3ac0b05c9ebe704d46e9fd661afbbdc7ecd16c48 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

@@ -402,7 +402,7 @@ class ContainerBuilder extends CodeEmitterHelper {

bool inInterceptor = backend.isInterceptedMethod(member);

List<String> fieldNames = <String>[];

compiler.boundClosureClass.forEachInstanceField((_, Element field) {

- fieldNames.add(namer.getNameOfInstanceMember(field));

+ fieldNames.add(namer.instanceFieldPropertyName(field));

});

ClassElement classElement = member.getEnclosingClass();

@@ -525,9 +525,7 @@ class ContainerBuilder extends CodeEmitterHelper {

? <jsAst.Expression>[js(receiverArgumentName)]

: <jsAst.Expression>[]);

} else {

- String fieldName = member.hasFixedBackendName()

- ? member.fixedBackendName()

- : namer.instanceFieldName(member);

+ String fieldName = namer.instanceFieldPropertyName(member);

return js('this')[fieldName];

}