Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: tests/lib/mirrors/reflect_model_test.dart

Issue 62373008: - Reverting mirror changes. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/mirrors/private_symbol_test.dart ('k') | tests/lib/mirrors/reflect_runtime_type_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/reflect_model_test.dart
===================================================================
--- tests/lib/mirrors/reflect_model_test.dart (revision 30028)
+++ tests/lib/mirrors/reflect_model_test.dart (working copy)
@@ -13,38 +13,6 @@
isNoSuchMethodError(e) => e is NoSuchMethodError;
-variablesOf(ClassMirror cm) {
- var result = new Map();
- cm.declarations.forEach((k,v) {
- if (v is VariableMirror) result[k] = v;
- });
- return result;
-}
-
-gettersOf(ClassMirror cm) {
- var result = new Map();
- cm.declarations.forEach((k,v) {
- if (v is MethodMirror && v.isGetter) result[k] = v;
- });
- return result;
-}
-
-settersOf(ClassMirror cm) {
- var result = new Map();
- cm.declarations.forEach((k,v) {
- if (v is MethodMirror && v.isSetter) result[k] = v;
- });
- return result;
-}
-
-methodsOf(ClassMirror cm) {
- var result = new Map();
- cm.declarations.forEach((k,v) {
- if (v is MethodMirror && v.isRegularMethod) result[k] = v;
- });
- return result;
-}
-
main() {
var unnamed = new Symbol('');
var field = new Symbol('field');
@@ -61,9 +29,9 @@
var b = bClass.newInstance(unnamed, []);
var c = cClass.newInstance(unnamed, []);
- expect('{field: Variable(s(field) in s(A))}', variablesOf(aClass));
- expect('{}', variablesOf(bClass));
- expect('{}', variablesOf(cClass));
+ expect('{field: Variable(s(field) in s(A))}', aClass.variables);
+ expect('{}', bClass.variables);
+ expect('{}', cClass.variables);
Expect.isNull(a.getField(field).reflectee);
Expect.equals('B:get field', b.getField(field).reflectee);
@@ -80,21 +48,21 @@
expect('{accessor: Method(s(accessor) in s(A), getter)'
'}',
- gettersOf(aClass));
+ aClass.getters);
expect('{accessor: Method(s(accessor) in s(B), getter)'
', field: Method(s(field) in s(B), getter)}',
- gettersOf(bClass));
+ bClass.getters);
expect('{accessor: Method(s(accessor) in s(C), getter)}',
- gettersOf(cClass));
+ cClass.getters);
expect('{accessor=: Method(s(accessor=) in s(A), setter)'
'}',
- settersOf(aClass));
+ aClass.setters);
expect('{accessor=: Method(s(accessor=) in s(B), setter)}',
- settersOf(bClass));
+ bClass.setters);
expect('{accessor=: Method(s(accessor=) in s(C), setter)'
', field=: Method(s(field=) in s(C), setter)}',
- settersOf(cClass));
+ cClass.setters);
Expect.equals('A:instanceMethod(7)', a.invoke(instanceMethod, [7]).reflectee);
Expect.equals('B:instanceMethod(9)', b.invoke(instanceMethod, [9]).reflectee);
@@ -104,16 +72,16 @@
expect(
'{aMethod: Method(s(aMethod) in s(A))'
', instanceMethod: Method(s(instanceMethod) in s(A))}',
- methodsOf(aClass));
+ aClass.methods);
expect(
'{bMethod: Method(s(bMethod) in s(B))'
', instanceMethod: Method(s(instanceMethod) in s(B))}',
- methodsOf(bClass));
+ bClass.methods);
expect(
'{cMethod: Method(s(cMethod) in s(C))'
', instanceMethod: Method(s(instanceMethod) in s(C))}',
- methodsOf(cClass));
+ cClass.methods);
Expect.equals('A:get accessor', a.getField(accessor).reflectee);
Expect.equals('B:get accessor', b.getField(accessor).reflectee);
« no previous file with comments | « tests/lib/mirrors/private_symbol_test.dart ('k') | tests/lib/mirrors/reflect_runtime_type_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698