Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: pkg/unittest/lib/mirror_matchers.dart

Issue 62373008: - Reverting mirror changes. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/serialization/lib/src/serialization_rule.dart ('k') | runtime/lib/mirrors_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/mirror_matchers.dart
===================================================================
--- pkg/unittest/lib/mirror_matchers.dart (revision 30028)
+++ pkg/unittest/lib/mirror_matchers.dart (working copy)
@@ -49,13 +49,7 @@
var mirror = reflect(item);
var classMirror = mirror.type;
var symbol = new Symbol(_name);
- bool hasGetter(classMirror, getterName) {
- var candidate = classMirror.declarations[getterName];
- return candidate != null &&
- candidate is MethodMirror &&
- candidate.isGetter;
- }
- if (!hasGetter(classMirror, symbol)) {
+ if (!classMirror.getters.containsKey(symbol)) {
addStateInfo(matchState, {'reason': 'has no property named "$_name"'});
return false;
}
« no previous file with comments | « pkg/serialization/lib/src/serialization_rule.dart ('k') | runtime/lib/mirrors_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698