Issue 62373004: Move the Ash NPAPI plugin blocker logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 62373004: Move the Ash NPAPI plugin blocker logic (Closed)

Created:
7 years, 1 month ago by cpu_(ooo_6.6-7.5)

Modified:
7 years, 1 month ago

Reviewers:
jam

CC:
chromium-reviews, stuartmorgan+watch_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move the Ash NPAPI plugin blocker logic To RenderviewCreated, so in theory there we can catch cases that we are missing, because we have a crash which is trying to reparent an NPAPI plugin in metro ash which should not be happening (should be blocked). BUG=315565 TEST=see bug R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233455

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -27 lines)			Patch
	M	chrome/browser/plugins/plugin_observer.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	chrome/browser/plugins/plugin_observer.cc	View	1	2 chunks	+19 lines, -25 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm https://codereview.chromium.org/62373004/diff/1/chrome/browser/plugins/plugin_observer.cc File chrome/browser/plugins/plugin_observer.cc (right): https://codereview.chromium.org/62373004/diff/1/chrome/browser/plugins/plugin_observer.cc#newcode194 chrome/browser/plugins/plugin_observer.cc:194: if (!web_contents()) this won't happen, so no need ...

7 years, 1 month ago (2013-11-07 00:13:07 UTC) #2

cpu_(ooo_6.6-7.5)

7 years, 1 month ago (2013-11-07 01:13:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r233455 (presubmit successful).

Expand Messages | Collapse Messages