Issue 623703004: Revert of Stitch ServiceWorkerCache between renderer and browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 623703004: Revert of Stitch ServiceWorkerCache between renderer and browser. (Closed)

Created:
6 years, 2 months ago by jkarlin

Modified:
6 years, 2 months ago

Reviewers:
michaeln, Tom Sepez, horo

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@gavin_code

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Stitch ServiceWorkerCache between renderer and browser. (patchset #8 id:140001 of https://codereview.chromium.org/580063003/) Reason for revert: Trybot tests were stale. Need to rebase and land again. Original issue's description: > Connect the ServiceWorkerCache functionality between the renderer and the browser. > > BUG=392621 > > Committed: https://crrev.com/a934835ea3e3091dc6f57681e5af74c257acd01f > Cr-Commit-Position: refs/heads/master@{#297848} TBR=michaeln@chromium.org,horo@chromium.org,tsepez@chromium.org NOTREECHECKS=true NOTRY=true BUG=392621 Committed: https://crrev.com/cae7450f0481f2d5e69668adc5cdbb48f1a34b45 Cr-Commit-Position: refs/heads/master@{#297850}

Patch Set 1 #

Created: 6 years, 2 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -198 lines)			Patch
	M	content/browser/service_worker/service_worker_cache_listener.h	View		3 chunks	+0 lines, -18 lines	0 comments	Download
	M	content/browser/service_worker/service_worker_cache_listener.cc	View		5 chunks	+9 lines, -180 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jkarlin

Created Revert of Stitch ServiceWorkerCache between renderer and browser.

6 years, 2 months ago (2014-10-02 16:43:14 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623703004/1

6 years, 2 months ago (2014-10-02 16:43:48 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as 66e9cc6db2f4bc4d695190b9e3c06e6f38f506c5

6 years, 2 months ago (2014-10-02 16:44:21 UTC) #3

commit-bot: I haz the power

6 years, 2 months ago (2014-10-02 16:44:55 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cae7450f0481f2d5e69668adc5cdbb48f1a34b45
Cr-Commit-Position: refs/heads/master@{#297850}

Expand Messages | Collapse Messages