DescriptionRevert of Make WindowState::CanMinimize() take into account WidgetDelegate::CanMinimize() (patchset #3 id:120001 of https://codereview.chromium.org/613563002/)
Reason for revert:
Suspected for failures on Linux ChromiumOS Tests (dbg)(1)
link:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/32143
browser_test LoginWebDialogTest.CannotMinimize failing with:
[12496:12496:1001/170357:FATAL:login_web_dialog.cc(148)] Check failed: false.
#2 0x0000026179dd chromeos::LoginWebDialog::OnCloseContents()
#3 0x7f542cba9b00 views::WebDialogView::OnCloseContents()
/* snip */
#24 0x7f5422726679 aura::Window::~Window()
#25 0x7f54244db0f8 ash::RootWindowController::CloseChildWindows()
#26 0x7f5424444bad ash::DisplayController::CloseChildWindows()
#27 0x7f542452db9b ash::Shell::~Shell()
#28 0x7f542452e869 ash::Shell::~Shell()
#29 0x7f542452a16f ash::Shell::DeleteInstance()
#30 0x000002dac13b chrome::CloseAsh()
#31 0x000002a0e111 ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun()
Original issue's description:
> Make WindowState::CanMinimize() take into account WidgetDelegate::CanMinimize()
>
> This has the side effect of disallowing minimizing bubbles (e.g. the bookmark
> bubble) via a gesture
>
> BUG=328241
> TEST=Manual, see bug
>
> Committed: https://crrev.com/ffacfd8c2841480e1e5775c124b63b351bddca69
> Cr-Commit-Position: refs/heads/master@{#297732}
TBR=oshima@chromium.org,sky@chromium.org,pkotwicz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=328241
Committed: https://crrev.com/7f79ce28848eb40d4ec6d2d335e2996ff02362e5
Cr-Commit-Position: refs/heads/master@{#297750}
Patch Set 1 #
Created: 6 years, 2 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|