Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 623613004: Revert of Make WindowState::CanMinimize() take into account WidgetDelegate::CanMinimize() (Closed)

Created:
6 years, 2 months ago by tapted
Modified:
6 years, 2 months ago
Reviewers:
pkotwicz, oshima, sky
CC:
chromium-reviews, tdanderson+views_chromium.org, ben+aura_chromium.org, tfarina, sadrul, kalyank, ben+views_chromium.org, ben+ash_chromium.org, jackhou1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Make WindowState::CanMinimize() take into account WidgetDelegate::CanMinimize() (patchset #3 id:120001 of https://codereview.chromium.org/613563002/) Reason for revert: Suspected for failures on Linux ChromiumOS Tests (dbg)(1) link: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/32143 browser_test LoginWebDialogTest.CannotMinimize failing with: [12496:12496:1001/170357:FATAL:login_web_dialog.cc(148)] Check failed: false. #2 0x0000026179dd chromeos::LoginWebDialog::OnCloseContents() #3 0x7f542cba9b00 views::WebDialogView::OnCloseContents() /* snip */ #24 0x7f5422726679 aura::Window::~Window() #25 0x7f54244db0f8 ash::RootWindowController::CloseChildWindows() #26 0x7f5424444bad ash::DisplayController::CloseChildWindows() #27 0x7f542452db9b ash::Shell::~Shell() #28 0x7f542452e869 ash::Shell::~Shell() #29 0x7f542452a16f ash::Shell::DeleteInstance() #30 0x000002dac13b chrome::CloseAsh() #31 0x000002a0e111 ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() Original issue's description: > Make WindowState::CanMinimize() take into account WidgetDelegate::CanMinimize() > > This has the side effect of disallowing minimizing bubbles (e.g. the bookmark > bubble) via a gesture > > BUG=328241 > TEST=Manual, see bug > > Committed: https://crrev.com/ffacfd8c2841480e1e5775c124b63b351bddca69 > Cr-Commit-Position: refs/heads/master@{#297732} TBR=oshima@chromium.org,sky@chromium.org,pkotwicz@chromium.org NOTREECHECKS=true NOTRY=true BUG=328241 Committed: https://crrev.com/7f79ce28848eb40d4ec6d2d335e2996ff02362e5 Cr-Commit-Position: refs/heads/master@{#297750}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -86 lines) Patch
M ash/frame/caption_buttons/frame_caption_button_container_view.h View 1 chunk +11 lines, -1 line 0 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc View 8 chunks +19 lines, -21 lines 0 comments Download
M ash/frame/caption_buttons/frame_size_button_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/frame/custom_frame_view_ash.cc View 1 chunk +6 lines, -1 line 0 comments Download
M ash/frame/default_header_painter_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/test/ash_test_base.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/panels/panel_frame_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 2 chunks +13 lines, -4 lines 0 comments Download
M ash/wm/window_state.cc View 1 chunk +9 lines, -1 line 0 comments Download
D chrome/browser/chromeos/login/ui/login_web_dialog_browsertest.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/client/aura_constants.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/aura/client/aura_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tapted
Created Revert of Make WindowState::CanMinimize() take into account WidgetDelegate::CanMinimize()
6 years, 2 months ago (2014-10-02 00:42:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623613004/1
6 years, 2 months ago (2014-10-02 00:44:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as f05174bbb891ced91dcfd4e5a6de5f7bf2bb2ddd
6 years, 2 months ago (2014-10-02 00:47:06 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 00:47:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f79ce28848eb40d4ec6d2d335e2996ff02362e5
Cr-Commit-Position: refs/heads/master@{#297750}

Powered by Google App Engine
This is Rietveld 408576698