[Local NTP] Fixing middle click paste in fakebox.

[Local NTP] Fixing middle click paste in fakebox.

- Allowing users to paste into the fakebox using the middle click, for supporter OS.

- Moving #fakebox-text behind #fakebox-input to prevent blocking.

BUG=370343
Committed: https://crrev.com/2178ddcc8351da2e8565df84a9812c4b23dd35f9
Cr-Commit-Position: refs/heads/master@{#297917}

[Georges Khalil, 2014-10-01 21:28:53]

georgesak@chromium.org changed reviewers:
+ huangs@chromium.org, mathp@chromium.org

[Georges Khalil, 2014-10-01 21:31:19]

PTAL

[huangs, 2014-10-01 21:49:41]

First round of comments.

https://codereview.chromium.org/623603002/diff/1/chrome/browser/resources/loc...
File chrome/browser/resources/local_ntp/local_ntp.js (right):

https://codereview.chromium.org/623603002/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp.js:1159: if (items.length > 0) {
Combine with "&&".

https://codereview.chromium.org/623603002/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp.js:1160: if (items[0].type ==
'text/plain') {
We should ensure that other text would work, e.g., 'text/html'.  So either that
doesn't happen, or we should handle these cases.

[Georges Khalil, 2014-10-01 22:22:21]

Done. PTAL.

https://codereview.chromium.org/623603002/diff/1/chrome/browser/resources/loc...
File chrome/browser/resources/local_ntp/local_ntp.js (right):

https://codereview.chromium.org/623603002/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp.js:1159: if (items.length > 0) {
On 2014/10/01 21:49:41, huangs1 wrote:
> Combine with "&&".

Done.

https://codereview.chromium.org/623603002/diff/1/chrome/browser/resources/loc...
chrome/browser/resources/local_ntp/local_ntp.js:1160: if (items[0].type ==
'text/plain') {
On 2014/10/01 21:49:41, huangs1 wrote:
> We should ensure that other text would work, e.g., 'text/html'.  So either
that
> doesn't happen, or we should handle these cases.

Per discussion, no problem here.

[Georges Khalil, 2014-10-02 15:42:22]

The CQ bit was checked by georgesak@chromium.org

[Georges Khalil, 2014-10-02 15:42:22]

The CQ bit was unchecked by georgesak@chromium.org

[huangs, 2014-10-02 19:02:54]

lgtm

[Mathieu, 2014-10-02 19:10:30]

lgtm, please wait for Sam's lgtm

https://codereview.chromium.org/623603002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/local_ntp/local_ntp.js (right):

https://codereview.chromium.org/623603002/diff/20001/chrome/browser/resources...
chrome/browser/resources/local_ntp/local_ntp.js:1157: // Send pasted text to
Omnibox.
nit: "Get the contents of the clipboard and explicitly send it to the browser."

https://codereview.chromium.org/623603002/diff/20001/chrome/browser/resources...
chrome/browser/resources/local_ntp/local_ntp.js:1159: if (items.length > 0 &&
items[0].type == 'text/plain') {
nit: if (items.length && ...

[huangs, 2014-10-02 20:40:55]

LGTM again.

[Georges Khalil, 2014-10-02 20:44:18]

The CQ bit was checked by georgesak@chromium.org

[commit-bot: I haz the power, 2014-10-02 20:45:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/623603002/40001

[commit-bot: I haz the power, 2014-10-02 22:00:09]

Committed patchset #3 (id:40001) as 30326b8f8861c7733b9ccfe9d1396408b137dbb9

[commit-bot: I haz the power, 2014-10-02 22:01:22]

Patchset 3 (id:??) landed as
https://crrev.com/2178ddcc8351da2e8565df84a9812c4b23dd35f9
Cr-Commit-Position: refs/heads/master@{#297917}