Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 623583003: Keep url by value in SSLErrorClassification. (Closed)

Created:
6 years, 2 months ago by meacer
Modified:
6 years, 2 months ago
Reviewers:
felt
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Keep url by value in SSLErrorClassification. Keeping a reference instead is causing a crash during shutdown in ASAN builds. BUG=419542 Committed: https://crrev.com/3c55b095c72fe1063453ac667c6fa09a9439ab6b Cr-Commit-Position: refs/heads/master@{#297737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ssl/ssl_error_classification.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
meacer
Can you please take a look? Thanks.
6 years, 2 months ago (2014-10-01 21:33:00 UTC) #2
felt
lgtm
6 years, 2 months ago (2014-10-01 21:37:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623583003/1
6 years, 2 months ago (2014-10-01 21:39:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0509c0249e1d30ec8ad4d499423a27f8fee6a802
6 years, 2 months ago (2014-10-01 23:47:47 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 23:48:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c55b095c72fe1063453ac667c6fa09a9439ab6b
Cr-Commit-Position: refs/heads/master@{#297737}

Powered by Google App Engine
This is Rietveld 408576698