Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5269)

Unified Diff: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

Issue 623573003: Disable FindInPageSpecialURLs and CommentsAndMetaDataNotSearchable on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
diff --git a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
index 83e24e8ff26d7a8aa907f2297b05862f49049d58..22a0f9e9ba097981c2fba91b12dbe1b27846082f 100644
--- a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
+++ b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
@@ -332,10 +332,16 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, MAYBE_SearchWithinSpecialURL) {
kFwd, kIgnoreCase, NULL));
}
+#if defined(OS_MACOSX)
+// Disabled due to http://crbug.com/419769.
+#define MAYBE_FindInPageSpecialURLs DISABLED_FindInPageSpecialURLs
+#else
+#define MAYBE_FindInPageSpecialURLs FindInPageSpecialURLs
+#endif
// Verify search selection coordinates. The data file used is set-up such that
// the text occurs on the same line, and we verify their positions by verifying
// their relative positions.
-IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindInPageSpecialURLs) {
+IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, MAYBE_FindInPageSpecialURLs) {
std::wstring search_string(L"\u5728\u897f\u660c\u536b\u661f\u53d1");
gfx::Rect first, second, first_reverse;
WebContents* web_contents =
@@ -361,9 +367,16 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindInPageSpecialURLs) {
ASSERT_EQ(first, first_reverse);
}
+#if defined(OS_MACOSX)
+// Disabled due to http://crbug.com/419769.
+#define MAYBE_CommentsAndMetaDataNotSearchable \
+ DISABLED_CommentsAndMetaDataNotSearchable
+#else
+#define MAYBE_CommentsAndMetaDataNotSearchable CommentsAndMetaDataNotSearchable
+#endif
// Verifies that comments and meta data are not searchable.
IN_PROC_BROWSER_TEST_F(FindInPageControllerTest,
- CommentsAndMetaDataNotSearchable) {
+ MAYBE_CommentsAndMetaDataNotSearchable) {
WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
ui_test_utils::NavigateToURL(browser(), GetURL("specialchar.html"));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698