Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 623573002: Mojo: Convert the remaining OVERRIDEs to override in mojo/. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, dcheng, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Convert the remaining OVERRIDEs to override in mojo/. R=sky@chromium.org Committed: https://crrev.com/84c4531b424fa78100a98c6482d9c3d0f8166660 Cr-Commit-Position: refs/heads/master@{#297703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+457 lines, -435 lines) Patch
M mojo/aura/context_factory_mojo.h View 2 chunks +9 lines, -8 lines 0 comments Download
M mojo/aura/context_factory_mojo.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M mojo/aura/screen_mojo.h View 2 chunks +13 lines, -13 lines 0 comments Download
M mojo/aura/window_tree_host_mojo.h View 2 chunks +18 lines, -18 lines 0 comments Download
M mojo/examples/aura_demo/aura_demo.cc View 5 chunks +20 lines, -19 lines 0 comments Download
M mojo/examples/browser/browser.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M mojo/examples/compositor_app/compositor_app.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/examples/compositor_app/compositor_host.h View 2 chunks +12 lines, -13 lines 0 comments Download
M mojo/examples/embedded_app/embedded_app.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/examples/keyboard/keyboard.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/examples/keyboard/keyboard_view.h View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/examples/media_viewer/media_viewer.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M mojo/examples/nesting_app/nesting_app.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/examples/pepper_container_app/graphics_3d_resource.h View 3 chunks +18 lines, -19 lines 0 comments Download
M mojo/examples/pepper_container_app/mojo_ppapi_globals.h View 2 chunks +12 lines, -13 lines 0 comments Download
M mojo/examples/pepper_container_app/mojo_ppapi_globals.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M mojo/examples/pepper_container_app/pepper_container_app.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/examples/pepper_container_app/plugin_instance.h View 1 chunk +60 lines, -60 lines 0 comments Download
M mojo/examples/pepper_container_app/resource_creation_impl.h View 5 chunks +56 lines, -57 lines 0 comments Download
M mojo/examples/png_viewer/png_viewer.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M mojo/examples/surfaces_app/child_app.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/examples/surfaces_app/child_gl_app.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M mojo/examples/surfaces_app/child_gl_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/examples/surfaces_app/child_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/examples/surfaces_app/surfaces_app.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/examples/window_manager/debug_panel.h View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/examples/window_manager/window_manager.cc View 12 chunks +18 lines, -18 lines 0 comments Download
M mojo/examples/wm_flow/app/app.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/examples/wm_flow/embedded/embedded.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/examples/wm_flow/wm/frame_controller.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M mojo/services/clipboard/clipboard_standalone_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/services/clipboard/main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/gles2/command_buffer_impl.h View 2 chunks +8 lines, -7 lines 0 comments Download
M mojo/services/gles2/command_buffer_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/gles2/mojo_buffer_backing.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/html_document_view.h View 2 chunks +6 lines, -6 lines 0 comments Download
M mojo/services/html_viewer/html_viewer.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M mojo/services/html_viewer/weblayertreeview_impl.h View 3 chunks +34 lines, -33 lines 0 comments Download
M mojo/services/html_viewer/websockethandle_impl.h View 2 chunks +5 lines, -4 lines 0 comments Download
M mojo/services/html_viewer/websockethandle_impl.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M mojo/services/html_viewer/webthread_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/weburlloader_impl.h View 2 chunks +5 lines, -4 lines 0 comments Download
M mojo/services/native_viewport/gpu_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/native_viewport/main.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_impl.h View 2 chunks +11 lines, -10 lines 0 comments Download
M mojo/services/native_viewport/platform_viewport_android.h View 2 chunks +9 lines, -8 lines 0 comments Download
M mojo/services/native_viewport/platform_viewport_headless.h View 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
This skips some files that are being deleted (in a CL that's in the CQ). ...
6 years, 2 months ago (2014-10-01 19:34:32 UTC) #1
sky
rubber stamp LGTM
6 years, 2 months ago (2014-10-01 19:49:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623573002/1
6 years, 2 months ago (2014-10-01 19:51:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 94ab2eaf46a4f7d119f26d72e885bbbdd5db860c
6 years, 2 months ago (2014-10-01 20:51:06 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 20:51:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84c4531b424fa78100a98c6482d9c3d0f8166660
Cr-Commit-Position: refs/heads/master@{#297703}

Powered by Google App Engine
This is Rietveld 408576698