Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 623563002: Don't adjust the bounds after a restore with the restore's paired saveLayer's paint. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org, Stephen White
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Don't adjust the bounds after a restore with the restore's paired saveLayer's paint. It makes no sense for the paint from a saveLayer to effect anything outside its saveLayer/restore block. But as currently written, we'll adjust the clip bounds just after a restore by that paint. Turns out the test I wrote for the last CL (which caused this bug) actually had the bug baked into its expectations. I've updated them and added some notes to explain. BUG=418417 Committed: https://skia.googlesource.com/skia/+/8e393bf70ea2aab9ca31f52c15b518436c7b6055

Patch Set 1 #

Patch Set 2 : Comments and refactor. #

Patch Set 3 : unused #

Patch Set 4 : more notes etc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -18 lines) Patch
M src/core/SkRecordDraw.cpp View 1 2 3 3 chunks +26 lines, -13 lines 0 comments Download
M tests/RecordDrawTest.cpp View 2 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtklein
6 years, 2 months ago (2014-10-01 19:19:14 UTC) #3
mtklein
6 years, 2 months ago (2014-10-01 19:19:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623563002/60001
6 years, 2 months ago (2014-10-01 19:19:37 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-01 19:19:38 UTC) #6
robertphillips
lgtm
6 years, 2 months ago (2014-10-01 19:30:40 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 19:49:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 8e393bf70ea2aab9ca31f52c15b518436c7b6055

Powered by Google App Engine
This is Rietveld 408576698