Drop some unused code

Drop some unused code

Bonus: fix bitrot in (disabled) Hydrogen-BCH

R=yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=24392

[Jakob Kummerow, 2014-10-01 16:06:23]

jkummerow@chromium.org changed reviewers:
+ yangguo@chromium.org

[Jakob Kummerow, 2014-10-01 16:06:24]

Some fallout from the last round of bug investigations. PTAL.

[Yang, 2014-10-02 09:54:13]

LGTM.

https://codereview.chromium.org/623513002/diff/1/src/hydrogen-bch.cc
File src/hydrogen-bch.cc (right):

https://codereview.chromium.org/623513002/diff/1/src/hydrogen-bch.cc#newcode245
src/hydrogen-bch.cc:245: has_upper_constant_limit &&
current_check->HasUpperLimit() &&
This seems like a bug fix rather and a mechanical change.

[Jakob Kummerow, 2014-10-02 10:52:26]

Committed patchset #1 (id:1) manually as 24392 (presubmit successful).

[realprincewall, 2015-02-21 01:12:08]

On 2014/10/02 10:52:26, Jakob wrote:
> Committed patchset #1 (id:1) manually as 24392 (presubmit successful).

The changes in src/hydrogen-instructions.cc seem incorrect. If SMI is allowed,
the increment needs to be adjusted for SMI (shift right by 1).

[Jakob Kummerow, 2015-02-21 17:15:13]

On 2015/02/21 01:12:08, realprincewall wrote:
> The changes in src/hydrogen-instructions.cc seem incorrect. If SMI is allowed,
> the increment needs to be adjusted for SMI (shift right by 1).

No, I believe the code is correct. Hydrogen instructions provide a level of
abstraction that means you don't have to worry about Smi shifts.

Or do you have a test case that exhibits wrong behavior?