Serialize external strings in the code serializer.

Handle external strings in the code serializer.

R=mvstanton@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=24378

[Yang, 2014-10-01 14:14:18]

Please take a look!

[mvstanton, 2014-10-01 14:26:22]

Nice solution. LGTM, just one comment about a nice to have in the test.

https://codereview.chromium.org/623453003/diff/1/test/cctest/test-serialize.cc
File test/cctest/test-serialize.cc (right):

https://codereview.chromium.org/623453003/diff/1/test/cctest/test-serialize.c...
test/cctest/test-serialize.cc:954:
two_byte_string->MakeExternal(&two_byte_resource);
I like these tests. Nit: Is it possible to check that the external string for
"one_byte" and "two_byte" do not exist in the context that you deserialize into?
That would verify that you don't create an external string, but just an
internalized string. I guess you'd have to make a new handle scope for that?

[Yang, 2014-10-02 07:12:54]

Committed patchset #1 (id:1) manually as 24378 (presubmit successful).

[Yang, 2014-10-02 07:13:15]

On 2014/10/01 14:26:22, mvstanton wrote:
> Nice solution. LGTM, just one comment about a nice to have in the test.
> 
> https://codereview.chromium.org/623453003/diff/1/test/cctest/test-serialize.cc
> File test/cctest/test-serialize.cc (right):
> 
>
https://codereview.chromium.org/623453003/diff/1/test/cctest/test-serialize.c...
> test/cctest/test-serialize.cc:954:
> two_byte_string->MakeExternal(&two_byte_resource);
> I like these tests. Nit: Is it possible to check that the external string for
> "one_byte" and "two_byte" do not exist in the context that you deserialize
into?
> That would verify that you don't create an external string, but just an
> internalized string. I guess you'd have to make a new handle scope for that?

As talked about offline, there is no test in place to check the string type
after serialization, and I don't think it's necessary.