Fix another silly mistake for debug c runtime dlls.

Fix another silly mistake for debug c runtime dlls.

BUG=414808
TBR=scottmg@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/6eddb5833a80c108e785b9a3f556d5fd0afcb0de

[jam, 2014-10-02 01:37:54]

even more facepalm

[commit-bot: I haz the power, 2014-10-02 01:40:01]

Patchset 1 (id:??) landed as
https://crrev.com/6eddb5833a80c108e785b9a3f556d5fd0afcb0de
Cr-Commit-Position: refs/heads/master@{#297758}

[jam, 2014-10-02 01:40:06]

Committed patchset #1 (id:1) manually as
6eddb5833a80c108e785b9a3f556d5fd0afcb0de.

[scottmg, 2014-10-02 02:53:26]

lgtm

https://codereview.chromium.org/623433005/diff/1/base/base.isolate
File base/base.isolate (right):

https://codereview.chromium.org/623433005/diff/1/base/base.isolate#newcode37
base/base.isolate:37: '<(PRODUCT_DIR)/msvcr120.dll',
probably should add x64/msvc[rp]120.dll here? or they don't seem necessary?
probably only would be required for a component=shared_library Release build

[jam, 2014-10-02 03:20:41]

https://codereview.chromium.org/623433005/diff/1/base/base.isolate
File base/base.isolate (right):

https://codereview.chromium.org/623433005/diff/1/base/base.isolate#newcode37
base/base.isolate:37: '<(PRODUCT_DIR)/msvcr120.dll',
On 2014/10/02 02:53:25, scottmg wrote:
> probably should add x64/msvc[rp]120.dll here? or they don't seem necessary?
> probably only would be required for a component=shared_library Release build

we don't use that anywhere. i'm hesitant to do stuff ahead of time for a config
that we may never support, and probably would need lots of other changes if we
decide to (at that point, i'd rather make the changes then because we can verify
what we're doing)

[scottmg, 2014-10-02 03:22:27]

sg.

On Wed, Oct 1, 2014 at 8:20 PM, <jam@chromium.org> wrote:

>
> https://codereview.chromium.org/623433005/diff/1/base/base.isolate
> File base/base.isolate (right):
>
> https://codereview.chromium.org/623433005/diff/1/base/
> base.isolate#newcode37
> base/base.isolate:37: '<(PRODUCT_DIR)/msvcr120.dll',
> On 2014/10/02 02:53:25, scottmg wrote:
>
>> probably should add x64/msvc[rp]120.dll here? or they don't seem
>>
> necessary?
>
>> probably only would be required for a component=shared_library Release
>>
> build
>
> we don't use that anywhere. i'm hesitant to do stuff ahead of time for a
> config that we may never support, and probably would need lots of other
> changes if we decide to (at that point, i'd rather make the changes then
> because we can verify what we're doing)
>
>
> https://codereview.chromium.org/623433005/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.