chrome/android/java/ChromeVersionConstants.java.version - Issue 623403002: Generate ChromeVersionConstants.java at build time.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/ChromeVersionConstants.java.version

Issue 623403002: Generate ChromeVersionConstants.java at build time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 package org.chromium.chrome.browser;

	6

	7 public class ChromeVersionConstants {

	8 public static final String PRODUCT_NAME = "@PRODUCT_FULLNAME@";
	Yaron 2014/10/06 15:45:38 Hmm. I think these two would allow us to clean up Hmm. I think these two would allow us to clean up some other cludge in the settings UI. newt (away) 2014/10/06 16:39:13 Yes, possibly so :) Show quoted text On 2014/10/06 15:45:38, Yaron wrote: > Hmm. I think these two would allow us to clean up some other cludge in the > settings UI. Yes, possibly so :)
	9 public static final String PRODUCT_VERSION = "@MAJOR@.@MINOR@.@BUILD@.@PATCH @";

	10 public static final boolean IS_OFFICIAL_BUILD = @OFFICIAL_BUILD@ == 1;

	11 }

OLD	NEW