Align base::hash_map with C++11, part 2.

content/renderer/pepper/v8_var_converter.cc

Index: content/renderer/pepper/v8_var_converter.cc
diff --git a/content/renderer/pepper/v8_var_converter.cc b/content/renderer/pepper/v8_var_converter.cc
index 3c3503046a9ab3dbc2dfba51a9fcfbd7e2add162..215ec389bee611d31ce610a6a74ea85644717a28 100644
--- a/content/renderer/pepper/v8_var_converter.cc
+++ b/content/renderer/pepper/v8_var_converter.cc
@@ -47,21 +47,16 @@ struct HashedHandle {
   HashedHandle(v8::Handle<v8::Object> h) : handle(h) {}
   size_t hash() const { return handle->GetIdentityHash(); }
   bool operator==(const HashedHandle& h) const { return handle == h.handle; }
-  bool operator<(const HashedHandle& h) const { return hash() < h.hash(); }

[davidben, 2014/10/06 23:37:24]

I left the other operator<'s in place because it wasn't immediately clear
whether a std::map of them would have made sense in each case...

...except this one. This one looks pretty clearly nonsense. Unless
GetIdentityHash() is secretly GetIdentityUniqueValue(), we weren't handling hash
collisions on MSVC's hash_map. It doesn't use operator==.

   v8::Handle<v8::Object> handle;
 };
 
 }  // namespace
 
 namespace BASE_HASH_NAMESPACE {
-#if defined(COMPILER_GCC)
 template <>
 struct hash<HashedHandle> {
   size_t operator()(const HashedHandle& handle) const { return handle.hash(); }
 };
-#elif defined(COMPILER_MSVC)
-inline size_t hash_value(const HashedHandle& handle) { return handle.hash(); }
-#endif
 }  // namespace BASE_HASH_NAMESPACE
 
 namespace content {