Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8882)

Unified Diff: chrome/browser/ui/window_sizer/window_sizer.cc

Issue 62333015: Ensure that the first browser window which is created in Windows 8 ASH is maximized. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/window_sizer/window_sizer.cc
===================================================================
--- chrome/browser/ui/window_sizer/window_sizer.cc (revision 236094)
+++ chrome/browser/ui/window_sizer/window_sizer.cc (working copy)
@@ -188,8 +188,7 @@
if (IsTabbedBrowserInAsh()) {
GetTabbedBrowserBoundsAsh(bounds, show_state);
return;
- } else if (chrome::ShouldOpenAshOnStartup() &&
- browser_ && browser_->host_desktop_type() ==
+ } else if (browser_ && browser_->host_desktop_type() ==
chrome::HOST_DESKTOP_TYPE_ASH) {
// In ash, saved show state takes precidence. If you have a
// question or an issue, please contact oshima@chromium.org.
@@ -399,17 +398,13 @@
#if defined(USE_ASH)
bool WindowSizer::IsTabbedBrowserInAsh() const {
- // TODO(beng): insufficient but currently necessary. http://crbug.com/133312
- return chrome::ShouldOpenAshOnStartup() &&
- browser_ &&
+ return browser_ &&
browser_->host_desktop_type() == chrome::HOST_DESKTOP_TYPE_ASH &&
browser_->is_type_tabbed();
}
bool WindowSizer::IsPopupBrowserInAsh() const {
- // TODO(beng): insufficient but currently necessary. http://crbug.com/133312
- return chrome::ShouldOpenAshOnStartup() &&
- browser_ &&
+ return browser_ &&
browser_->host_desktop_type() == chrome::HOST_DESKTOP_TYPE_ASH &&
browser_->is_type_popup();
}

Powered by Google App Engine
This is Rietveld 408576698