Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 62333004: Make win_rel contain all the targets that are in win7_aura in preparation for removing that confi... (Closed)

Created:
7 years, 1 month ago by jam
Modified:
7 years, 1 month ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Make win_rel contain all the targets that are in win7_aura in preparation for removing that config. BUG=316199 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=234441

Patch Set 1 #

Patch Set 2 : only add new targets for now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M projects.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jam
7 years, 1 month ago (2013-11-07 21:39:04 UTC) #1
ghost stip (do not use)
lgtm
7 years, 1 month ago (2013-11-07 21:57:48 UTC) #2
Paweł Hajdan Jr.
LGTM I recommend testing this change locally using this command: "./commit_queue.py --fake --no-try --project chromium" ...
7 years, 1 month ago (2013-11-07 22:24:51 UTC) #3
jam
On 2013/11/07 22:24:51, Paweł Hajdan Jr. wrote: > LGTM > > I recommend testing this ...
7 years, 1 month ago (2013-11-07 22:29:26 UTC) #4
Paweł Hajdan Jr.
On 2013/11/07 22:29:26, jam wrote: > commit_queue.py: error: .gaia_pwd is missing. Please read workdir/README. > ...
7 years, 1 month ago (2013-11-08 00:08:51 UTC) #5
jam
On 2013/11/08 00:08:51, Paweł Hajdan Jr. wrote: > On 2013/11/07 22:29:26, jam wrote: > > ...
7 years, 1 month ago (2013-11-08 00:34:07 UTC) #6
jam
Per the discussion on https://codereview.chromium.org/64723003/, I've split this change into being just adding new targets ...
7 years, 1 month ago (2013-11-08 01:08:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/62333004/90001
7 years, 1 month ago (2013-11-12 06:59:18 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 06:59:33 UTC) #9
Message was sent while issue was closed.
Change committed as 234441

Powered by Google App Engine
This is Rietveld 408576698