chrome/browser/chromeos/memory/low_memory_observer.cc - Issue 623293003: replace OVERRIDE and FINAL with override and final in chrome/browser/chromeos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/memory/low_memory_observer.cc

Issue 623293003: replace OVERRIDE and FINAL with override and final in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: run git cl format on echo_dialog_view.h Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/wizard_controller_browsertest.cc ('k') | chrome/browser/chromeos/memory/oom_priority_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/memory/low_memory_observer.cc

diff --git a/chrome/browser/chromeos/memory/low_memory_observer.cc b/chrome/browser/chromeos/memory/low_memory_observer.cc

index 7f30bdbdd2166537f1c431c9f2b04bc02bc3b4c4..e1a63b63404230a63dc6c8b4038d2ea4847488e5 100644

--- a/chrome/browser/chromeos/memory/low_memory_observer.cc

+++ b/chrome/browser/chromeos/memory/low_memory_observer.cc

@@ -80,8 +80,8 @@ class LowMemoryObserverImpl

virtual ~FileWatcherDelegate() {}

// Overrides for base::MessageLoopForIO::Watcher

- virtual void OnFileCanWriteWithoutBlocking(int fd) OVERRIDE {}

- virtual void OnFileCanReadWithoutBlocking(int fd) OVERRIDE {

+ virtual void OnFileCanWriteWithoutBlocking(int fd) override {}

+ virtual void OnFileCanReadWithoutBlocking(int fd) override {

LOG(WARNING) << "Low memory condition detected. Discarding a tab.";

// We can only discard tabs on the UI thread.

base::Callback<void(void)> callback = base::Bind(&DiscardTab);