Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Side by Side Diff: chrome/browser/chromeos/input_method/input_method_engine_unittest.cc

Issue 623293003: replace OVERRIDE and FINAL with override and final in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: run git cl format on echo_dialog_view.h Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/logging.h" 5 #include "base/logging.h"
6 #include "base/metrics/histogram.h" 6 #include "base/metrics/histogram.h"
7 #include "base/metrics/histogram_samples.h" 7 #include "base/metrics/histogram_samples.h"
8 #include "base/metrics/statistics_recorder.h" 8 #include "base/metrics/statistics_recorder.h"
9 #include "base/test/histogram_tester.h" 9 #include "base/test/histogram_tester.h"
10 #include "chrome/browser/chromeos/input_method/input_method_configuration.h" 10 #include "chrome/browser/chromeos/input_method/input_method_configuration.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 manager->SetComponentExtensionIMEManager( 58 manager->SetComponentExtensionIMEManager(
59 scoped_ptr<ComponentExtensionIMEManager>(comp_ime_manager).Pass()); 59 scoped_ptr<ComponentExtensionIMEManager>(comp_ime_manager).Pass());
60 InitializeForTesting(manager); 60 InitializeForTesting(manager);
61 } 61 }
62 62
63 class TestObserver : public InputMethodEngineInterface::Observer { 63 class TestObserver : public InputMethodEngineInterface::Observer {
64 public: 64 public:
65 TestObserver() : calls_bitmap_(NONE) {} 65 TestObserver() : calls_bitmap_(NONE) {}
66 virtual ~TestObserver() {} 66 virtual ~TestObserver() {}
67 67
68 virtual void OnActivate(const std::string& engine_id) OVERRIDE { 68 virtual void OnActivate(const std::string& engine_id) override {
69 calls_bitmap_ |= ACTIVATE; 69 calls_bitmap_ |= ACTIVATE;
70 } 70 }
71 virtual void OnDeactivated(const std::string& engine_id) OVERRIDE { 71 virtual void OnDeactivated(const std::string& engine_id) override {
72 calls_bitmap_ |= DEACTIVATED; 72 calls_bitmap_ |= DEACTIVATED;
73 } 73 }
74 virtual void OnFocus( 74 virtual void OnFocus(
75 const InputMethodEngineInterface::InputContext& context) OVERRIDE { 75 const InputMethodEngineInterface::InputContext& context) override {
76 calls_bitmap_ |= ONFOCUS; 76 calls_bitmap_ |= ONFOCUS;
77 } 77 }
78 virtual void OnBlur(int context_id) OVERRIDE { 78 virtual void OnBlur(int context_id) override {
79 calls_bitmap_ |= ONBLUR; 79 calls_bitmap_ |= ONBLUR;
80 } 80 }
81 virtual void OnKeyEvent( 81 virtual void OnKeyEvent(
82 const std::string& engine_id, 82 const std::string& engine_id,
83 const InputMethodEngineInterface::KeyboardEvent& event, 83 const InputMethodEngineInterface::KeyboardEvent& event,
84 input_method::KeyEventHandle* key_data) OVERRIDE {} 84 input_method::KeyEventHandle* key_data) override {}
85 virtual void OnInputContextUpdate( 85 virtual void OnInputContextUpdate(
86 const InputMethodEngineInterface::InputContext& context) OVERRIDE {} 86 const InputMethodEngineInterface::InputContext& context) override {}
87 virtual void OnCandidateClicked( 87 virtual void OnCandidateClicked(
88 const std::string& engine_id, 88 const std::string& engine_id,
89 int candidate_id, 89 int candidate_id,
90 InputMethodEngineInterface::MouseButtonEvent button) OVERRIDE {} 90 InputMethodEngineInterface::MouseButtonEvent button) override {}
91 virtual void OnMenuItemActivated( 91 virtual void OnMenuItemActivated(
92 const std::string& engine_id, 92 const std::string& engine_id,
93 const std::string& menu_id) OVERRIDE {} 93 const std::string& menu_id) override {}
94 virtual void OnSurroundingTextChanged( 94 virtual void OnSurroundingTextChanged(
95 const std::string& engine_id, 95 const std::string& engine_id,
96 const std::string& text, 96 const std::string& text,
97 int cursor_pos, 97 int cursor_pos,
98 int anchor_pos) OVERRIDE {} 98 int anchor_pos) override {}
99 virtual void OnReset(const std::string& engine_id) OVERRIDE {} 99 virtual void OnReset(const std::string& engine_id) override {}
100 100
101 unsigned char GetCallsBitmapAndReset() { 101 unsigned char GetCallsBitmapAndReset() {
102 unsigned char ret = calls_bitmap_; 102 unsigned char ret = calls_bitmap_;
103 calls_bitmap_ = NONE; 103 calls_bitmap_ = NONE;
104 return ret; 104 return ret;
105 } 105 }
106 106
107 private: 107 private:
108 unsigned char calls_bitmap_; 108 unsigned char calls_bitmap_;
109 109
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 &error); 244 &error);
245 engine_->CommitText(1, "input\xE5\x85\xA5\xE5\x8A\x9B", &error); 245 engine_->CommitText(1, "input\xE5\x85\xA5\xE5\x8A\x9B", &error);
246 histograms.ExpectTotalCount("InputMethod.CommitLength", 3); 246 histograms.ExpectTotalCount("InputMethod.CommitLength", 3);
247 histograms.ExpectBucketCount("InputMethod.CommitLength", 5, 1); 247 histograms.ExpectBucketCount("InputMethod.CommitLength", 5, 1);
248 histograms.ExpectBucketCount("InputMethod.CommitLength", 2, 1); 248 histograms.ExpectBucketCount("InputMethod.CommitLength", 2, 1);
249 histograms.ExpectBucketCount("InputMethod.CommitLength", 7, 1); 249 histograms.ExpectBucketCount("InputMethod.CommitLength", 7, 1);
250 } 250 }
251 251
252 } // namespace input_method 252 } // namespace input_method
253 } // namespace chromeos 253 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698