Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: chrome/browser/chromeos/external_metrics_unittest.cc

Issue 623293003: replace OVERRIDE and FINAL with override and final in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: run git cl format on echo_dialog_view.h Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/file_util.h" 5 #include "base/files/file_util.h"
6 #include "base/files/scoped_temp_dir.h" 6 #include "base/files/scoped_temp_dir.h"
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/metrics/statistics_recorder.h" 8 #include "base/metrics/statistics_recorder.h"
9 #include "base/test/histogram_tester.h" 9 #include "base/test/histogram_tester.h"
10 #include "chrome/browser/chromeos/external_metrics.h" 10 #include "chrome/browser/chromeos/external_metrics.h"
11 #include "components/metrics/serialization/metric_sample.h" 11 #include "components/metrics/serialization/metric_sample.h"
12 #include "components/metrics/serialization/serialization_utils.h" 12 #include "components/metrics/serialization/serialization_utils.h"
13 #include "content/public/test/test_browser_thread_bundle.h" 13 #include "content/public/test/test_browser_thread_bundle.h"
14 14
15 namespace chromeos { // Need this because of the FRIEND_TEST 15 namespace chromeos { // Need this because of the FRIEND_TEST
16 16
17 class ExternalMetricsTest : public testing::Test { 17 class ExternalMetricsTest : public testing::Test {
18 public: 18 public:
19 virtual void SetUp() OVERRIDE { 19 virtual void SetUp() override {
20 ASSERT_TRUE(dir_.CreateUniqueTempDir()); 20 ASSERT_TRUE(dir_.CreateUniqueTempDir());
21 external_metrics_ = ExternalMetrics::CreateForTesting( 21 external_metrics_ = ExternalMetrics::CreateForTesting(
22 dir_.path().Append("testfile").value()); 22 dir_.path().Append("testfile").value());
23 } 23 }
24 24
25 base::ScopedTempDir dir_; 25 base::ScopedTempDir dir_;
26 scoped_refptr<ExternalMetrics> external_metrics_; 26 scoped_refptr<ExternalMetrics> external_metrics_;
27 content::TestBrowserThreadBundle thread_bundle_; 27 content::TestBrowserThreadBundle thread_bundle_;
28 }; 28 };
29 29
(...skipping 27 matching lines...) Expand all
57 57
58 EXPECT_TRUE(metrics::SerializationUtils::WriteMetricToFile( 58 EXPECT_TRUE(metrics::SerializationUtils::WriteMetricToFile(
59 *hist.get(), external_metrics_->uma_events_file_)); 59 *hist.get(), external_metrics_->uma_events_file_));
60 60
61 external_metrics_->CollectEvents(); 61 external_metrics_->CollectEvents();
62 62
63 histogram_tester.ExpectTotalCount("bar", 0); 63 histogram_tester.ExpectTotalCount("bar", 0);
64 } 64 }
65 65
66 } // namespace chromeos 66 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698