net/base/escape.cc - Issue 623213004: replace OVERRIDE and FINAL with override and final in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/escape.cc

Issue 623213004: replace OVERRIDE and FINAL with override and final in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase on master Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/escape.cc

diff --git a/net/base/escape.cc b/net/base/escape.cc

index ab70f1db30187e6a28e09757819d2f307291fd53..dedb84eeb7e39752b90e2b15d5c2202aff97a74b 100644

--- a/net/base/escape.cc

+++ b/net/base/escape.cc

@@ -160,8 +160,8 @@ STR UnescapeURLWithAdjustmentsImpl(

// U+202A LEFT-TO-RIGHT EMBEDDING (%E2%80%AA)

// U+202B RIGHT-TO-LEFT EMBEDDING (%E2%80%AB)

// U+202C POP DIRECTIONAL FORMATTING (%E2%80%AC)

- // U+202D LEFT-TO-RIGHT OVERRIDE (%E2%80%AD)

- // U+202E RIGHT-TO-LEFT OVERRIDE (%E2%80%AE)

+ // U+202D LEFT-TO-RIGHT override (%E2%80%AD)

+ // U+202E RIGHT-TO-LEFT override (%E2%80%AE)

dcheng 2014/10/08 20:25:47 These look like incorrect replacements.

Mostyn Bramley-Moore 2014/10/08 20:48:30 Fixed in patchset 3. My cpp based cross-check did

// Additionally, the Unicode Technical Report (TR9) as referenced by RFC

// 3987 above has since added some new BiDi control characters.

« no previous file with comments | « net/base/dns_reloader.cc ('k') | net/base/file_stream_context.h » ('j') | no next file with comments »