Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: extensions/browser/guest_view/web_view/web_view_apitest.cc

Issue 623193002: Enabling two tests that were disabled in app_shell_browsertests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/web_view/web_view_apitest.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_apitest.cc b/extensions/browser/guest_view/web_view/web_view_apitest.cc
index 8aec95523f92c62cfcfd400f8c8ec4004fa1c5be..2d0a7e9b94ce6a1d1cd3f749b71e2b7c4ccfb6f0 100644
--- a/extensions/browser/guest_view/web_view/web_view_apitest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_apitest.cc
@@ -216,10 +216,7 @@ IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestDisplayNoneWebviewLoad) {
RunTest("testDisplayNoneWebviewLoad", "web_view/apitest");
}
-// TODO(lfg): Re-enable this test once the fix for webview leaking
-// RenderProcessHost has landed. See http://crbug.com/419020 .
-IN_PROC_BROWSER_TEST_F(WebViewAPITest,
- DISABLED_TestDisplayNoneWebviewRemoveChild) {
+IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestDisplayNoneWebviewRemoveChild) {
RunTest("testDisplayNoneWebviewRemoveChild", "web_view/apitest");
}
@@ -409,11 +406,9 @@ IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestRemoveSrcAttribute) {
RunTest("testRemoveSrcAttribute", "web_view/apitest");
}
-// TODO(lfg): Re-enable this test once the fix for webview leaking
-// RenderProcessHost has landed. See http://crbug.com/419020 .
-IN_PROC_BROWSER_TEST_F(WebViewAPITest,
- DISABLED_TestRemoveWebviewAfterNavigation) {
+IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestRemoveWebviewAfterNavigation) {
RunTest("testRemoveWebviewAfterNavigation", "web_view/apitest");
+ GetGuestViewManager()->WaitForGuestDeleted();
Fady Samuel 2014/10/03 20:51:36 Can we move this to the bottom of RunTest?
Fady Samuel 2014/10/03 20:59:28 LGTM. I like the idea of observing that every gues
}
IN_PROC_BROWSER_TEST_F(WebViewAPITest, TestResizeWebviewResizesContent) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698