Issue 623163004: Add MemorySnapshotMac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 623163004: Add MemorySnapshotMac (Closed)

Created:
6 years, 2 months ago by Mark Mentovai

Modified:
6 years, 2 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+133 lines, -0 lines)			Patch
A	snapshot/memory_snapshot_mac.h	View	1 chunk	+68 lines, -0 lines	0 comments	Download
A	snapshot/memory_snapshot_mac.cc	View	1 chunk	+63 lines, -0 lines	0 comments	Download
M	snapshot/snapshot.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

Here’s one that seems kind of pointless to test at all, because it basically just ...

6 years, 2 months ago (2014-10-03 18:40:45 UTC) #2

Robert Sesek

LGTM. Yes, the setup for the test seems like it'd be larger than the test ...

6 years, 2 months ago (2014-10-03 18:50:58 UTC) #3

Mark Mentovai

6 years, 2 months ago (2014-10-03 18:57:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6b451ea32a2eb45a7a5a773300044031f0d22a24 (presubmit successful).