Issue 6231550869897216: Remove dead code behind ENABLE(STREAM) guards

Issue 6231550869897216: Remove dead code behind ENABLE(STREAM) guards (Closed)

Created:
7 years, 5 months ago by adamk

Modified:
7 years, 5 months ago

Reviewers:
tyoshino (SeeGerritForStatus)

CC:
blink-reviews, kinuko, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove dead code behind ENABLE(STREAM) guards R=tyoshino@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154325

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -39 lines)			Patch
	M	Source/core/fileapi/FileReaderLoader.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
	M	Source/core/fileapi/FileReaderLoader.cpp	View		2 chunks	+0 lines, -33 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

adamk

Ping? Or is this code supposed to be alive? I see https://codereview.chromium.org/18991017/ landed, which looks ...

7 years, 5 months ago (2013-07-16 00:10:09 UTC) #2

tyoshino (SeeGerritForStatus)

LGTM I'll pick code needed for my work and reland later.

7 years, 5 months ago (2013-07-16 16:58:21 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/6231550869897216/5629499534213120

7 years, 5 months ago (2013-07-16 16:59:40 UTC) #4

commit-bot: I haz the power

Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=13006

7 years, 5 months ago (2013-07-16 19:19:54 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/6231550869897216/5629499534213120

7 years, 5 months ago (2013-07-16 19:24:05 UTC) #6

commit-bot: I haz the power

Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=13011

7 years, 5 months ago (2013-07-16 20:55:17 UTC) #7

adamk

7 years, 5 months ago (2013-07-16 21:07:37 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 manually as r154325 (presubmit successful).

Expand Messages | Collapse Messages