Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 623153004: app_shell: Add experimental shellPrivate extension API (Closed)

Created:
6 years, 2 months ago by James Cook
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

app_shell: Add experimental shellPrivate extension API This gives us a place to experiment with app_shell-specific identity work. Start with a throw-away "hello" API. BUG=420189 TEST=extensions_unittests ShellPrivateApiTest.* Committed: https://crrev.com/e99bfcb9de717ee2bf1d87f1367795bfa90436b9 Cr-Commit-Position: refs/heads/master@{#298164}

Patch Set 1 #

Total comments: 1

Patch Set 2 : (shell-private) remove comment #

Patch Set 3 : (shell-private) rebase #

Patch Set 4 : (shell-private) fix gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -0 lines) Patch
M extensions/browser/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A + extensions/browser/api/shell_private/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A extensions/browser/api/shell_private/shell_private_api.h View 1 chunk +32 lines, -0 lines 0 comments Download
A extensions/browser/api/shell_private/shell_private_api.cc View 1 chunk +21 lines, -0 lines 0 comments Download
A extensions/browser/api/shell_private/shell_private_api_unittest.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M extensions/common/api/_api_features.json View 1 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/common/api/schemas.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A extensions/common/api/shell_private.idl View 1 chunk +12 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
James Cook
rockot, PTAL
6 years, 2 months ago (2014-10-03 20:36:15 UTC) #2
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/623153004/diff/1/extensions/common/api/_api_features.json File extensions/common/api/_api_features.json (right): https://codereview.chromium.org/623153004/diff/1/extensions/common/api/_api_features.json#newcode72 extensions/common/api/_api_features.json:72: // TODO(jamescook): Should bluetooth be here? Yes, it ...
6 years, 2 months ago (2014-10-03 20:42:36 UTC) #3
James Cook
On 2014/10/03 20:42:36, Ken Rockot wrote: > lgtm > > https://codereview.chromium.org/623153004/diff/1/extensions/common/api/_api_features.json > File extensions/common/api/_api_features.json (right): ...
6 years, 2 months ago (2014-10-03 23:38:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623153004/1
6 years, 2 months ago (2014-10-03 23:44:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623153004/40001
6 years, 2 months ago (2014-10-03 23:58:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/5034) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/21755)
6 years, 2 months ago (2014-10-04 00:24:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623153004/60001
6 years, 2 months ago (2014-10-04 01:57:56 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 57a2c233846d59700d7a8d411118605433d6ef75
6 years, 2 months ago (2014-10-04 02:48:10 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-04 02:48:47 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e99bfcb9de717ee2bf1d87f1367795bfa90436b9
Cr-Commit-Position: refs/heads/master@{#298164}

Powered by Google App Engine
This is Rietveld 408576698