Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: components/cronet/android/chromium_url_request.cc

Issue 623133002: replace OVERRIDE and FINAL with override and final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/cronet/android/chromium_url_request.h" 5 #include "components/cronet/android/chromium_url_request.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "components/cronet/android/url_request_adapter.h" 10 #include "components/cronet/android/url_request_adapter.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 } 52 }
53 53
54 // A delegate of URLRequestAdapter that delivers callbacks to the Java layer. 54 // A delegate of URLRequestAdapter that delivers callbacks to the Java layer.
55 class JniURLRequestAdapterDelegate 55 class JniURLRequestAdapterDelegate
56 : public URLRequestAdapter::URLRequestAdapterDelegate { 56 : public URLRequestAdapter::URLRequestAdapterDelegate {
57 public: 57 public:
58 JniURLRequestAdapterDelegate(JNIEnv* env, jobject owner) { 58 JniURLRequestAdapterDelegate(JNIEnv* env, jobject owner) {
59 owner_ = env->NewGlobalRef(owner); 59 owner_ = env->NewGlobalRef(owner);
60 } 60 }
61 61
62 virtual void OnResponseStarted(URLRequestAdapter* request) OVERRIDE { 62 virtual void OnResponseStarted(URLRequestAdapter* request) override {
63 JNIEnv* env = base::android::AttachCurrentThread(); 63 JNIEnv* env = base::android::AttachCurrentThread();
64 cronet::Java_ChromiumUrlRequest_onResponseStarted(env, owner_); 64 cronet::Java_ChromiumUrlRequest_onResponseStarted(env, owner_);
65 } 65 }
66 66
67 virtual void OnBytesRead(URLRequestAdapter* request) OVERRIDE { 67 virtual void OnBytesRead(URLRequestAdapter* request) override {
68 int bytes_read = request->bytes_read(); 68 int bytes_read = request->bytes_read();
69 if (bytes_read != 0) { 69 if (bytes_read != 0) {
70 JNIEnv* env = base::android::AttachCurrentThread(); 70 JNIEnv* env = base::android::AttachCurrentThread();
71 base::android::ScopedJavaLocalRef<jobject> java_buffer( 71 base::android::ScopedJavaLocalRef<jobject> java_buffer(
72 env, env->NewDirectByteBuffer(request->Data(), bytes_read)); 72 env, env->NewDirectByteBuffer(request->Data(), bytes_read));
73 cronet::Java_ChromiumUrlRequest_onBytesRead( 73 cronet::Java_ChromiumUrlRequest_onBytesRead(
74 env, owner_, java_buffer.obj()); 74 env, owner_, java_buffer.obj());
75 } 75 }
76 } 76 }
77 77
78 virtual void OnRequestFinished(URLRequestAdapter* request) OVERRIDE { 78 virtual void OnRequestFinished(URLRequestAdapter* request) override {
79 JNIEnv* env = base::android::AttachCurrentThread(); 79 JNIEnv* env = base::android::AttachCurrentThread();
80 cronet::Java_ChromiumUrlRequest_finish(env, owner_); 80 cronet::Java_ChromiumUrlRequest_finish(env, owner_);
81 } 81 }
82 82
83 virtual int ReadFromUploadChannel(net::IOBuffer* buf, 83 virtual int ReadFromUploadChannel(net::IOBuffer* buf,
84 int buf_length) OVERRIDE { 84 int buf_length) override {
85 JNIEnv* env = base::android::AttachCurrentThread(); 85 JNIEnv* env = base::android::AttachCurrentThread();
86 base::android::ScopedJavaLocalRef<jobject> java_buffer( 86 base::android::ScopedJavaLocalRef<jobject> java_buffer(
87 env, env->NewDirectByteBuffer(buf->data(), buf_length)); 87 env, env->NewDirectByteBuffer(buf->data(), buf_length));
88 jint bytes_read = cronet::Java_ChromiumUrlRequest_readFromUploadChannel( 88 jint bytes_read = cronet::Java_ChromiumUrlRequest_readFromUploadChannel(
89 env, owner_, java_buffer.obj()); 89 env, owner_, java_buffer.obj());
90 return bytes_read; 90 return bytes_read;
91 } 91 }
92 92
93 protected: 93 protected:
94 virtual ~JniURLRequestAdapterDelegate() { 94 virtual ~JniURLRequestAdapterDelegate() {
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 URLRequestAdapter* request = 393 URLRequestAdapter* request =
394 reinterpret_cast<URLRequestAdapter*>(urlRequestAdapter); 394 reinterpret_cast<URLRequestAdapter*>(urlRequestAdapter);
395 if (request == NULL) 395 if (request == NULL)
396 return ConvertUTF8ToJavaString(env, "").Release(); 396 return ConvertUTF8ToJavaString(env, "").Release();
397 397
398 std::string negotiated_protocol = request->GetNegotiatedProtocol(); 398 std::string negotiated_protocol = request->GetNegotiatedProtocol();
399 return ConvertUTF8ToJavaString(env, negotiated_protocol.c_str()).Release(); 399 return ConvertUTF8ToJavaString(env, negotiated_protocol.c_str()).Release();
400 } 400 }
401 401
402 } // namespace cronet 402 } // namespace cronet
OLDNEW
« no previous file with comments | « components/crash/browser/crash_handler_host_linux.h ('k') | components/cronet/android/chromium_url_request_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698