Issue 623093002: bot_update: Pass custom_vars dict to deps2git.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 623093002: bot_update: Pass custom_vars dict to deps2git. (Closed)

Created:
6 years, 2 months ago by kjellander_chromium

Modified:
6 years, 2 months ago

Reviewers:
hinoka

CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build

Project:
tools

Visibility:
Public.

More Reviews

Description

bot_update: Pass custom_vars dict to deps2git. To make use of the ability to override the variables in the DEPS file that is supported once https://codereview.chromium.org/619133002/ is landed. BUG=419516

Patch Set 1 #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	scripts/slave/bot_update.py	View		2 chunks	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kjellander_chromium

https://codereview.chromium.org/623093002/diff/1/scripts/slave/bot_update.py File scripts/slave/bot_update.py (right): https://codereview.chromium.org/623093002/diff/1/scripts/slave/bot_update.py#newcode838 scripts/slave/bot_update.py:838: cmd.extend(['--var_overrides', json.dumps(custom_vars)]) I doublechecked that an empty custom_vars dict ...

6 years, 2 months ago (2014-10-03 09:00:50 UTC) #2

kjellander_chromium

6 years, 2 months ago (2014-10-09 09:28:18 UTC) #3

I'm abandoning this CL since I removed the use of the custom_vars "root_dir"
variable that WebRTC had on the bots until now.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages