Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 623003002: QUIC: if client provides an STK which includes CachedNetworkParams, then (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)
Modified:
6 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

QUIC: if client provides an STK which includes CachedNetworkParams, then store these and echo them back in future STKs if we have no newer estimate to send. Flag protected behind disabled FLAGS_quic_store_cached_network_params_from_chlo. This is the followup to adding timestamp to the SourceAddressToken proto. This allowed us to copy a previously provided CachedNetworkParams into new STKs without losing timestamp data. It also paves the way for recording BW estimate accuracy in the server: we now have the client's provided BW estimate stored per connection, so we can compare against BW that we see on the new connection (this will be in a future CL). Merge internal change: 76455340 R=rch@chromium.org chromium: this code doesn't impact client side code because we don't parse SourceAddressToken (we keep it as a string). For QUIC server, we are not parsing optional cached_network_params. Added a TODO to convert SourcAddressToken and CachedNetworkParams to protobuf.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -71 lines) Patch
M net/quic/crypto/quic_crypto_server_config.h View 4 chunks +46 lines, -6 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 9 chunks +43 lines, -49 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config_test.cc View 4 chunks +40 lines, -4 lines 0 comments Download
M net/quic/crypto/source_address_token.h View 3 chunks +10 lines, -0 lines 0 comments Download
M net/quic/crypto/source_address_token.cc View 1 chunk +28 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_server_stream.h View 2 chunks +9 lines, -1 line 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 4 chunks +13 lines, -3 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_server_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 2 months ago (2014-10-03 03:27:17 UTC) #1
Ryan Hamilton
6 years, 2 months ago (2014-10-10 22:47:22 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698