Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 622893002: [Easy Unlock] Fix a DCHECK: Load localized string correctly. (Closed)

Created:
6 years, 2 months ago by Ilya Sherman
Modified:
6 years, 2 months ago
Reviewers:
tbarzic
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Easy Unlock] Fix a DCHECK: Load localized string correctly. BUG=none TEST=none R=tbarzic@chromium.org Committed: https://crrev.com/7f42587503b82f232ca18cc48c2d033c61890fe2 Cr-Commit-Position: refs/heads/master@{#297919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Ilya Sherman
6 years, 2 months ago (2014-10-02 21:05:50 UTC) #1
tbarzic
lgtm
6 years, 2 months ago (2014-10-02 21:08:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622893002/1
6 years, 2 months ago (2014-10-02 21:11:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as bb60fdabddb92c75ba72edb20c61491a375f5803
6 years, 2 months ago (2014-10-02 22:01:40 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 22:02:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f42587503b82f232ca18cc48c2d033c61890fe2
Cr-Commit-Position: refs/heads/master@{#297919}

Powered by Google App Engine
This is Rietveld 408576698