Chromecast: adds interfaces for hardware layer of CMA pipeline.

Chromecast: adds interfaces for hardware layer of CMA pipeline.

R=damienv@chromium.org,lcwu@chromium.org
BUG=408189
Committed: https://crrev.com/6346166732c9bf991694d968742f352bac8445e9
Cr-Commit-Position: refs/heads/master@{#298350}

[gunsch, 2014-10-02 16:19:18]

PTAL, thanks!

[gunsch, 2014-10-03 00:07:51]

On 2014/10/02 16:19:18, gunsch wrote:
> PTAL, thanks!

FYI: I took Damien's suggestion offline to split this into two CLs,
https://codereview.chromium.org/609383004/ is first. Once that's reviewed, the
backend has little to no footprint on media/ APIs and is mostly Chromecast's own
custom interface to be implemented for each hardware implementation.

[gunsch, 2014-10-03 16:31:22]

gunsch@chromium.org changed reviewers:
- xhwang@chromium.org

[gunsch, 2014-10-03 16:31:53]

On 2014/10/03 00:07:51, gunsch wrote:
> On 2014/10/02 16:19:18, gunsch wrote:
> > PTAL, thanks!
> 
> FYI: I took Damien's suggestion offline to split this into two CLs,
> https://codereview.chromium.org/609383004/ is first. Once that's reviewed, the
> backend has little to no footprint on media/ APIs and is mostly Chromecast's
own
> custom interface to be implemented for each hardware implementation.

Rebased this onto the other in-flight CL. This should be much simpler to review
now and doesn't require any DEPS approval. PTAL!

[damienv1, 2014-10-03 22:19:42]

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
File chromecast/media/cma/backend/audio_pipeline_device.cc (right):

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_pipeline_device.cc:18: 
Remove last line.

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
File chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc
(right):

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:3: // found
in the LICENSE file.
I think the whole unit test has been updated in the mean time.
Could you please update the CL ?

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:254:
ConfigureForVideoOnly("bear.h264", /* raw_h264 */ true);
Note: we introduce a dependency on Chrome test media data:
chromium/src/media/test/data
I don't know if DEPS is only w.r.t. code.

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
File chromecast/media/cma/backend/media_clock_device.h (right):

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
chromecast/media/cma/backend/media_clock_device.h:12: #include
"base/memory/ref_counted.h"
Not needed.

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
chromecast/media/cma/backend/media_clock_device.h:84: 
Last line.

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
File chromecast/media/cma/backend/media_component_device.h (right):

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
chromecast/media/cma/backend/media_component_device.h:141: 
Remove last line.

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
File chromecast/media/cma/backend/media_pipeline_device.h (right):

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
chromecast/media/cma/backend/media_pipeline_device.h:21: struct CreateParameters
{
I would rather have sth like: MediaPipelineDeviceParams (a bit in the same way
there is a WebMediaPlayerParams) and move it outside of the MediaPipelineDevice
class so forward declaration can be possible.

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
File chromecast/media/cma/backend/video_pipeline_device.h (right):

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
chromecast/media/cma/backend/video_pipeline_device.h:64: 
Last line.

[gunsch, 2014-10-03 23:08:45]

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
File chromecast/media/cma/backend/audio_pipeline_device.cc (right):

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_pipeline_device.cc:18: 
On 2014/10/03 22:19:41, damienv1 wrote:
> Remove last line.

Done.

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
File chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc
(right):

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:3: // found
in the LICENSE file.
On 2014/10/03 22:19:41, damienv1 wrote:
> I think the whole unit test has been updated in the mean time.
> Could you please update the CL ?

Huh, so it was. Updated.

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:254:
ConfigureForVideoOnly("bear.h264", /* raw_h264 */ true);
On 2014/10/03 22:19:41, damienv1 wrote:
> Note: we introduce a dependency on Chrome test media data:
> chromium/src/media/test/data
> I don't know if DEPS is only w.r.t. code.

Only w.r.t header includes. Even gyp DEPS are okay.

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
File chromecast/media/cma/backend/media_clock_device.h (right):

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
chromecast/media/cma/backend/media_clock_device.h:12: #include
"base/memory/ref_counted.h"
On 2014/10/03 22:19:41, damienv1 wrote:
> Not needed.

Done.

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
chromecast/media/cma/backend/media_clock_device.h:84: 
On 2014/10/03 22:19:42, damienv1 wrote:
> Last line.

Done.

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
File chromecast/media/cma/backend/media_component_device.h (right):

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
chromecast/media/cma/backend/media_component_device.h:141: 
On 2014/10/03 22:19:42, damienv1 wrote:
> Remove last line.

Done.

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
File chromecast/media/cma/backend/media_pipeline_device.h (right):

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
chromecast/media/cma/backend/media_pipeline_device.h:21: struct CreateParameters
{
On 2014/10/03 22:19:42, damienv1 wrote:
> I would rather have sth like: MediaPipelineDeviceParams (a bit in the same way
> there is a WebMediaPlayerParams) and move it outside of the
MediaPipelineDevice
> class so forward declaration can be possible.

Done.

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
File chromecast/media/cma/backend/video_pipeline_device.h (right):

https://codereview.chromium.org/622853002/diff/40001/chromecast/media/cma/bac...
chromecast/media/cma/backend/video_pipeline_device.h:64: 
On 2014/10/03 22:19:42, damienv1 wrote:
> Last line.

Done.

[damienv1, 2014-10-03 23:33:45]

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
File chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc
(right):

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:76: bool
raw_h264);
nit: Could go on the previous line.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:79: //  
pauses, then pausing for >= pattern[i].length against MessageLoop
nit: extra spaces not needed

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:81: void
SetPausePattern(const std::vector<PauseInfo> pattern);
Blank line.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:130: //
Copy pattern
Copy could be removed. Does not help.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:136: 
nit: No blank line needed.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:143: 
Not blank line needed.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:150:
LoadVideoStream(filename, /* raw_h264 */ false);
Style ?

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:172:
MediaComponentDeviceFeederForTest *device_feeder =
Style: Test*

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:213:
/*audio*/ false);
Style issue ?

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:262:
media_clock_device_->SetState(MediaClockDevice::kStateRunning);
Does not seem the right place. Why not make it part of Start ?

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:281:
pause_pattern_[pause_pattern_idx_].length);
nit: Add a return and remove the else.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:325: }
nit: Add blank line.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:365:
ConfigureForVideoOnly("bear.h264", /* raw_h264 */ true);
Style issue ? /* raw_h264 */
I don't remember having seen this kind of inline comment.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:373:
ConfigureForVideoOnly("bear-640x360.webm", /* raw_h264 */ false);
Same.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:376:
AddPause(base::TimeDelta::FromMilliseconds(500),
nit: to keep the same style (i.e. group Configure/Start/Run), AddPause could be
moved before ConfigureForVideoOnly without any side effect.

[damienv1, 2014-10-03 23:43:34]

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/tes...
File chromecast/media/cma/test/media_component_device_feeder_for_test.h (right):

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/tes...
chromecast/media/cma/test/media_component_device_feeder_for_test.h:24: typedef
std::list<scoped_refptr<DecoderBufferBase> > FrameList;
The name is different for the same structure in one of the test file.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/tes...
chromecast/media/cma/test/media_component_device_feeder_for_test.h:31:
base::Callback<void(MediaComponentDeviceFeederForTest *)> eos_cb);
|eos_cb| should be just a closure. Seems a bit weird.
In that case, it would be better to pass eos_cb as part of Initialize and let
the caller bind it with the MediaComponentDeviceFeederForTest.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/tes...
chromecast/media/cma/test/media_component_device_feeder_for_test.h:43: void
SetDelayedFeedPattern(const std::vector<base::TimeDelta>& pattern);
Does not seem to be used anymore. Please check with Kyle and Sergey since this
was a way to generate some underrun (which won't be the case anymore since
feeding is much faster than playback).

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/tes...
chromecast/media/cma/test/media_component_device_feeder_for_test.h:64:
base::Callback<void(MediaComponentDeviceFeederForTest *)> eos_cb_;
Should just be a closure.

[gunsch, 2014-10-04 00:37:41]

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
File chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc
(right):

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:76: bool
raw_h264);
On 2014/10/03 23:33:45, damienv1 wrote:
> nit: Could go on the previous line.

Done.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:79: //  
pauses, then pausing for >= pattern[i].length against MessageLoop
On 2014/10/03 23:33:45, damienv1 wrote:
> nit: extra spaces not needed

Done.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:81: void
SetPausePattern(const std::vector<PauseInfo> pattern);
On 2014/10/03 23:33:44, damienv1 wrote:
> Blank line.

Done.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:130: //
Copy pattern
On 2014/10/03 23:33:44, damienv1 wrote:
> Copy could be removed. Does not help.

Done.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:136: 
On 2014/10/03 23:33:44, damienv1 wrote:
> nit: No blank line needed.

Done.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:143: 
On 2014/10/03 23:33:45, damienv1 wrote:
> Not blank line needed.

Done.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:150:
LoadVideoStream(filename, /* raw_h264 */ false);
On 2014/10/03 23:33:45, damienv1 wrote:
> Style ?

Done.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:172:
MediaComponentDeviceFeederForTest *device_feeder =
On 2014/10/03 23:33:45, damienv1 wrote:
> Style: Test*

Done.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:213:
/*audio*/ false);
On 2014/10/03 23:33:45, damienv1 wrote:
> Style issue ? 

Done.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:262:
media_clock_device_->SetState(MediaClockDevice::kStateRunning);
On 2014/10/03 23:33:44, damienv1 wrote:
> Does not seem the right place. Why not make it part of Start ?

Done.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:281:
pause_pattern_[pause_pattern_idx_].length);
On 2014/10/03 23:33:45, damienv1 wrote:
> nit: Add a return and remove the else.

Done.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:325: }
On 2014/10/03 23:33:44, damienv1 wrote:
> nit: Add blank line.

Done.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:365:
ConfigureForVideoOnly("bear.h264", /* raw_h264 */ true);
On 2014/10/03 23:33:45, damienv1 wrote:
> Style issue ? /* raw_h264 */
> I don't remember having seen this kind of inline comment.

Common, but usually on the other side. Updated all.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:373:
ConfigureForVideoOnly("bear-640x360.webm", /* raw_h264 */ false);
On 2014/10/03 23:33:45, damienv1 wrote:
> Same.

Done.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:376:
AddPause(base::TimeDelta::FromMilliseconds(500),
On 2014/10/03 23:33:45, damienv1 wrote:
> nit: to keep the same style (i.e. group Configure/Start/Run), AddPause could
be
> moved before ConfigureForVideoOnly without any side effect.

Done.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/tes...
File chromecast/media/cma/test/media_component_device_feeder_for_test.h (right):

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/tes...
chromecast/media/cma/test/media_component_device_feeder_for_test.h:24: typedef
std::list<scoped_refptr<DecoderBufferBase> > FrameList;
On 2014/10/03 23:43:34, damienv1 wrote:
> The name is different for the same structure in one of the test file.

Done.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/tes...
chromecast/media/cma/test/media_component_device_feeder_for_test.h:31:
base::Callback<void(MediaComponentDeviceFeederForTest *)> eos_cb);
On 2014/10/03 23:43:34, damienv1 wrote:
> |eos_cb| should be just a closure. Seems a bit weird.
> In that case, it would be better to pass eos_cb as part of Initialize and let
> the caller bind it with the MediaComponentDeviceFeederForTest.

Sort of hard to bind the object, since you have to create the object first :)
Moved it to Initialize

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/tes...
chromecast/media/cma/test/media_component_device_feeder_for_test.h:43: void
SetDelayedFeedPattern(const std::vector<base::TimeDelta>& pattern);
On 2014/10/03 23:43:34, damienv1 wrote:
> Does not seem to be used anymore. Please check with Kyle and Sergey since this
> was a way to generate some underrun (which won't be the case anymore since
> feeding is much faster than playback).

Done.

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/tes...
chromecast/media/cma/test/media_component_device_feeder_for_test.h:64:
base::Callback<void(MediaComponentDeviceFeederForTest *)> eos_cb_;
On 2014/10/03 23:43:34, damienv1 wrote:
> Should just be a closure.

Done.

[damienv1, 2014-10-06 17:00:24]

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/tes...
File chromecast/media/cma/test/media_component_device_feeder_for_test.h (right):

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/tes...
chromecast/media/cma/test/media_component_device_feeder_for_test.h:43: void
SetDelayedFeedPattern(const std::vector<base::TimeDelta>& pattern);
On 2014/10/04 00:37:40, gunsch wrote:
> On 2014/10/03 23:43:34, damienv1 wrote:
> > Does not seem to be used anymore. Please check with Kyle and Sergey since
this
> > was a way to generate some underrun (which won't be the case anymore since
> > feeding is much faster than playback).
> 
> Done.

So, not interested in generating some underruns anymore ?

https://codereview.chromium.org/622853002/diff/80001/chromecast/media/cma/bac...
File chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc
(right):

https://codereview.chromium.org/622853002/diff/80001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:5: #include
<list>
nit: Not used.

https://codereview.chromium.org/622853002/diff/80001/chromecast/media/cma/bac...
File chromecast/media/cma/backend/media_pipeline_device_fake.cc (right):

https://codereview.chromium.org/622853002/diff/80001/chromecast/media/cma/bac...
chromecast/media/cma/backend/media_pipeline_device_fake.cc:37: virtual
base::TimeDelta GetTime() OVERRIDE;
Replace OVERRIDE with override everywhere in this CL.

https://codereview.chromium.org/622853002/diff/80001/chromecast/media/cma/tes...
File chromecast/media/cma/test/media_component_device_feeder_for_test.h (right):

https://codereview.chromium.org/622853002/diff/80001/chromecast/media/cma/tes...
chromecast/media/cma/test/media_component_device_feeder_for_test.h:50: // Frame
index where the clock device is switching to the kStateRunning
nit: consistency (add "." as the end).

[gunsch, 2014-10-06 17:19:51]

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/tes...
File chromecast/media/cma/test/media_component_device_feeder_for_test.h (right):

https://codereview.chromium.org/622853002/diff/60001/chromecast/media/cma/tes...
chromecast/media/cma/test/media_component_device_feeder_for_test.h:43: void
SetDelayedFeedPattern(const std::vector<base::TimeDelta>& pattern);
On 2014/10/06 17:00:23, damienv1 wrote:
> On 2014/10/04 00:37:40, gunsch wrote:
> > On 2014/10/03 23:43:34, damienv1 wrote:
> > > Does not seem to be used anymore. Please check with Kyle and Sergey since
> this
> > > was a way to generate some underrun (which won't be the case anymore since
> > > feeding is much faster than playback).
> > 
> > Done.
> 
> So, not interested in generating some underruns anymore ?

Sergey said it was fine to remove. I'm sure we can always re-add from git logs
if it is needed again.

https://codereview.chromium.org/622853002/diff/80001/chromecast/media/cma/bac...
File chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc
(right):

https://codereview.chromium.org/622853002/diff/80001/chromecast/media/cma/bac...
chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc:5: #include
<list>
On 2014/10/06 17:00:23, damienv1 wrote:
> nit: Not used.

Done.

https://codereview.chromium.org/622853002/diff/80001/chromecast/media/cma/tes...
File chromecast/media/cma/test/media_component_device_feeder_for_test.h (right):

https://codereview.chromium.org/622853002/diff/80001/chromecast/media/cma/tes...
chromecast/media/cma/test/media_component_device_feeder_for_test.h:50: // Frame
index where the clock device is switching to the kStateRunning
On 2014/10/06 17:00:23, damienv1 wrote:
> nit: consistency (add "." as the end).

Done.

[damienv1, 2014-10-06 17:25:24]

lgtm

[gunsch, 2014-10-06 17:37:53]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2014-10-06 17:40:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/622853002/100001

[gunsch, 2014-10-06 21:32:28]

The CQ bit was unchecked by gunsch@chromium.org

[gunsch, 2014-10-06 23:27:14]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2014-10-06 23:31:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/622853002/100001

[commit-bot: I haz the power, 2014-10-07 03:29:34]

Committed patchset #6 (id:100001) as 7cebb78b29a60554813b70083b73e8a55bb83397

[commit-bot: I haz the power, 2014-10-07 03:30:25]

Patchset 6 (id:??) landed as
https://crrev.com/6346166732c9bf991694d968742f352bac8445e9
Cr-Commit-Position: refs/heads/master@{#298350}