Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 622843002: DevTools: Support timeline JS sampling for all threads. (Closed)

Created:
6 years, 2 months ago by alph
Modified:
6 years, 1 month ago
Reviewers:
yurys, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Support timeline JS sampling for all threads. BUG=363976 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185121

Patch Set 1 #

Patch Set 2 : Drop now unused arg #

Patch Set 3 : Rebaseline #

Total comments: 4

Patch Set 4 : Rebaseline. #

Total comments: 4

Patch Set 5 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -47 lines) Patch
M Source/devtools/front_end/timeline/TimelineJSProfile.js View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingModel.js View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 1 2 3 9 chunks +59 lines, -42 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
alph
ptal. This patch depends on TracingModel.Thread.target is implemented: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/devtools/front_end/timeline/TracingModel.js&q=tracingmodel&sq=package:chromium&type=cs&l=740
6 years, 2 months ago (2014-10-02 16:16:37 UTC) #2
alph
ping
6 years, 2 months ago (2014-10-06 09:54:23 UTC) #3
loislo
https://codereview.chromium.org/622843002/diff/40001/Source/devtools/front_end/timeline/TracingTimelineModel.js File Source/devtools/front_end/timeline/TracingTimelineModel.js (right): https://codereview.chromium.org/622843002/diff/40001/Source/devtools/front_end/timeline/TracingTimelineModel.js#newcode177 Source/devtools/front_end/timeline/TracingTimelineModel.js:177: this._configureCpuProfilerSamplingInterval(target); what would happen when we start another worker ...
6 years, 2 months ago (2014-10-10 17:13:08 UTC) #4
alph
ping https://codereview.chromium.org/622843002/diff/40001/Source/devtools/front_end/timeline/TracingTimelineModel.js File Source/devtools/front_end/timeline/TracingTimelineModel.js (right): https://codereview.chromium.org/622843002/diff/40001/Source/devtools/front_end/timeline/TracingTimelineModel.js#newcode177 Source/devtools/front_end/timeline/TracingTimelineModel.js:177: this._configureCpuProfilerSamplingInterval(target); On 2014/10/10 17:13:08, loislo wrote: > what ...
6 years, 1 month ago (2014-11-11 10:18:07 UTC) #5
yurys
lgtm https://codereview.chromium.org/622843002/diff/80001/Source/devtools/front_end/timeline/TracingModel.js File Source/devtools/front_end/timeline/TracingModel.js (right): https://codereview.chromium.org/622843002/diff/80001/Source/devtools/front_end/timeline/TracingModel.js#newcode810 Source/devtools/front_end/timeline/TracingModel.js:810: //FIXME: correctly specify target We should add a ...
6 years, 1 month ago (2014-11-11 10:37:32 UTC) #6
alph
https://codereview.chromium.org/622843002/diff/80001/Source/devtools/front_end/timeline/TracingModel.js File Source/devtools/front_end/timeline/TracingModel.js (right): https://codereview.chromium.org/622843002/diff/80001/Source/devtools/front_end/timeline/TracingModel.js#newcode810 Source/devtools/front_end/timeline/TracingModel.js:810: //FIXME: correctly specify target On 2014/11/11 10:37:32, yurys wrote: ...
6 years, 1 month ago (2014-11-11 10:59:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622843002/100001
6 years, 1 month ago (2014-11-11 11:00:41 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 12:09:45 UTC) #10
Message was sent while issue was closed. 
Committed patchset #5 (id:100001) as 185121

Powered by Google App Engine
This is Rietveld 408576698