Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3469)

Unified Diff: cc/layers/picture_layer_impl_unittest.cc

Issue 62283012: cc: Added tile bundles (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/picture_layer_impl.cc ('k') | cc/resources/picture_layer_tiling.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/picture_layer_impl_unittest.cc
diff --git a/cc/layers/picture_layer_impl_unittest.cc b/cc/layers/picture_layer_impl_unittest.cc
index ef69963cdffb1071dda68605712ad35d50502c52..d4b0280884ab0034c8e98b3570dead26c3ed8c84 100644
--- a/cc/layers/picture_layer_impl_unittest.cc
+++ b/cc/layers/picture_layer_impl_unittest.cc
@@ -93,9 +93,9 @@ class PictureLayerImplTest : public testing::Test {
void CreateHighLowResAndSetAllTilesVisible() {
// Active layer must get updated first so pending layer can share from it.
- active_layer_->CreateDefaultTilingsAndTiles();
+ active_layer_->CreateDefaultTilingsAndTiles(ACTIVE_TREE);
active_layer_->SetAllTilesVisible();
- pending_layer_->CreateDefaultTilingsAndTiles();
+ pending_layer_->CreateDefaultTilingsAndTiles(PENDING_TREE);
pending_layer_->SetAllTilesVisible();
}
@@ -103,11 +103,16 @@ class PictureLayerImplTest : public testing::Test {
active_layer_->AddTiling(2.3f);
active_layer_->AddTiling(1.0f);
active_layer_->AddTiling(0.5f);
- for (size_t i = 0; i < active_layer_->tilings()->num_tilings(); ++i)
- active_layer_->tilings()->tiling_at(i)->CreateAllTilesForTesting();
+ for (size_t i = 0; i < active_layer_->tilings()->num_tilings(); ++i) {
+ active_layer_->tilings()->tiling_at(i)->CreateTilesForTesting(
+ ACTIVE_TREE);
+ }
pending_layer_->set_invalidation(invalidation);
- for (size_t i = 0; i < pending_layer_->tilings()->num_tilings(); ++i)
- pending_layer_->tilings()->tiling_at(i)->CreateAllTilesForTesting();
+ for (size_t i = 0; i < pending_layer_->tilings()->num_tilings(); ++i) {
+ pending_layer_->tilings()
+ ->tiling_at(i)
+ ->CreateTilesForTesting(PENDING_TREE);
+ }
}
void SetupPendingTree(
@@ -169,14 +174,14 @@ class PictureLayerImplTest : public testing::Test {
}
void AssertAllTilesRequired(PictureLayerTiling* tiling) {
- std::vector<Tile*> tiles = tiling->AllTilesForTesting();
+ std::vector<Tile*> tiles = tiling->TilesForTesting(PENDING_TREE);
for (size_t i = 0; i < tiles.size(); ++i)
EXPECT_TRUE(tiles[i]->required_for_activation()) << "i: " << i;
EXPECT_GT(tiles.size(), 0u);
}
void AssertNoTilesRequired(PictureLayerTiling* tiling) {
- std::vector<Tile*> tiles = tiling->AllTilesForTesting();
+ std::vector<Tile*> tiles = tiling->TilesForTesting(PENDING_TREE);
for (size_t i = 0; i < tiles.size(); ++i)
EXPECT_FALSE(tiles[i]->required_for_activation()) << "i: " << i;
EXPECT_GT(tiles.size(), 0u);
@@ -1217,7 +1222,6 @@ TEST_F(PictureLayerImplTest, MarkRequiredOffscreenTiles) {
++iter) {
if (!*iter)
continue;
- Tile* tile = *iter;
TilePriority priority;
priority.resolution = HIGH_RESOLUTION;
if (++tile_count % 2) {
@@ -1227,7 +1231,7 @@ TEST_F(PictureLayerImplTest, MarkRequiredOffscreenTiles) {
priority.time_to_visible_in_seconds = 1.f;
priority.distance_to_visible_in_pixels = 1.f;
}
- tile->SetPriority(PENDING_TREE, priority);
+ iter.SetPriorityForTesting(priority);
}
pending_layer_->MarkVisibleResourcesAsRequired();
@@ -1244,7 +1248,7 @@ TEST_F(PictureLayerImplTest, MarkRequiredOffscreenTiles) {
if (!*iter)
continue;
const Tile* tile = *iter;
- if (tile->priority(PENDING_TREE).distance_to_visible_in_pixels == 0.f) {
+ if (iter.priority().distance_to_visible_in_pixels == 0.f) {
EXPECT_TRUE(tile->required_for_activation());
num_visible++;
} else {
@@ -1315,7 +1319,8 @@ TEST_F(PictureLayerImplTest, NothingRequiredIfActiveMissingTiles) {
// Active layer has tilings, but no tiles due to missing recordings.
EXPECT_TRUE(active_layer_->CanHaveTilings());
EXPECT_EQ(active_layer_->tilings()->num_tilings(), 2u);
- EXPECT_EQ(active_layer_->HighResTiling()->AllTilesForTesting().size(), 0u);
+ EXPECT_EQ(active_layer_->HighResTiling()->TilesForTesting(ACTIVE_TREE).size(),
+ 0u);
// Since the active layer has no tiles at all, the pending layer doesn't
// need content in order to activate. This is attempting to simulate
« no previous file with comments | « cc/layers/picture_layer_impl.cc ('k') | cc/resources/picture_layer_tiling.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698