Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: cc/resources/picture_layer_tiling.h

Issue 62283012: cc: Added tile bundles (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: perftest fix Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/picture_layer_tiling.h
diff --git a/cc/resources/picture_layer_tiling.h b/cc/resources/picture_layer_tiling.h
index 7d7626e74706f2f06e8395fd381e9d896aa45943..71236a80eeb105203804aef9beac3768db5b2c5d 100644
--- a/cc/resources/picture_layer_tiling.h
+++ b/cc/resources/picture_layer_tiling.h
@@ -15,6 +15,7 @@
#include "cc/base/region.h"
#include "cc/base/tiling_data.h"
#include "cc/resources/tile.h"
+#include "cc/resources/tile_bundle.h"
#include "cc/resources/tile_priority.h"
#include "ui/gfx/rect.h"
@@ -29,12 +30,18 @@ class CC_EXPORT PictureLayerTilingClient {
virtual scoped_refptr<Tile> CreateTile(
PictureLayerTiling* tiling,
gfx::Rect content_rect) = 0;
+ virtual scoped_refptr<TileBundle> CreateTileBundle(int width,
+ int height,
+ int offset_x,
+ int offset_y) = 0;
virtual void UpdatePile(Tile* tile) = 0;
virtual gfx::Size CalculateTileSize(
gfx::Size content_bounds) const = 0;
virtual const Region* GetInvalidation() = 0;
virtual const PictureLayerTiling* GetTwinTiling(
const PictureLayerTiling* tiling) = 0;
+ virtual bool IsActive() const = 0;
+ virtual bool IsPending() const = 0;
protected:
virtual ~PictureLayerTilingClient() {}
@@ -67,14 +74,37 @@ class CC_EXPORT PictureLayerTiling {
float contents_scale() const { return contents_scale_; }
void CreateAllTilesForTesting() {
- SetLiveTilesRect(gfx::Rect(tiling_data_.total_size()));
+ SetLiveTilesRect(ACTIVE_TREE, gfx::Rect(tiling_data_.total_size()));
+ live_tiles_rect_ = gfx::Rect();
+ SetLiveTilesRect(PENDING_TREE, gfx::Rect(tiling_data_.total_size()));
+ }
+
+ void CreateAllPendingTilesForTesting() {
+ SetLiveTilesRect(PENDING_TREE, gfx::Rect(tiling_data_.total_size()));
+ }
+ void CreateAllActiveTilesForTesting() {
+ SetLiveTilesRect(ACTIVE_TREE, gfx::Rect(tiling_data_.total_size()));
}
std::vector<Tile*> AllTilesForTesting() const {
std::vector<Tile*> all_tiles;
- for (TileMap::const_iterator it = tiles_.begin();
- it != tiles_.end(); ++it)
- all_tiles.push_back(it->second.get());
+ for (TileBundleMap::const_iterator it = tile_bundles_.begin();
+ it != tile_bundles_.end(); ++it) {
+ for (TileBundle::Iterator tile_it(it->second.get()); tile_it; ++tile_it)
+ all_tiles.push_back(*tile_it);
+ }
+ return all_tiles;
+ }
+
+ std::vector<Tile*> AllPendingTilesForTesting() const {
+ std::vector<Tile*> all_tiles;
+ for (TileBundleMap::const_iterator it = tile_bundles_.begin();
+ it != tile_bundles_.end(); ++it) {
+ for (TileBundle::Iterator tile_it(it->second.get()); tile_it; ++tile_it) {
+ if (!tile_it.active_tree_only_tile())
+ all_tiles.push_back(*tile_it);
+ }
+ }
return all_tiles;
}
@@ -104,6 +134,9 @@ class CC_EXPORT PictureLayerTiling {
Tile* operator->() const { return current_tile_; }
Tile* operator*() const { return current_tile_; }
+ TilePriority priority();
+ void SetPriorityForTesting(const TilePriority& priority);
+
CoverageIterator& operator++();
operator bool() const { return tile_j_ <= bottom_; }
@@ -120,6 +153,7 @@ class CC_EXPORT PictureLayerTiling {
int top_;
int right_;
int bottom_;
+ WhichTree tree_;
friend class PictureLayerTiling;
};
@@ -184,15 +218,28 @@ class CC_EXPORT PictureLayerTiling {
}
protected:
- typedef std::pair<int, int> TileMapKey;
- typedef base::hash_map<TileMapKey, scoped_refptr<Tile> > TileMap;
+ friend class TileBundle;
+
+ typedef std::pair<int, int> TileBundleMapKey;
+ typedef base::hash_map<TileBundleMapKey, scoped_refptr<TileBundle> >
+ TileBundleMap;
PictureLayerTiling(float contents_scale,
gfx::Size layer_bounds,
PictureLayerTilingClient* client);
- void SetLiveTilesRect(gfx::Rect live_tiles_rect);
- void CreateTile(int i, int j, const PictureLayerTiling* twin_tiling);
- Tile* TileAt(int, int) const;
+ void SetLiveTilesRect(WhichTree tree, gfx::Rect live_tiles_rect);
+ void CreateTile(WhichTree tree,
+ int i,
+ int j,
+ const PictureLayerTiling* twin_tiling);
+ bool RemoveTile(WhichTree tree, int i, int j);
+ void RemoveBundleIfEmptyContainingTileAt(int i, int j);
+ Tile* TileAt(WhichTree tree, int, int) const;
+ TileBundle* TileBundleContainingTileAt(int, int) const;
+ TileBundle* CreateBundleForTileAt(int,
+ int,
+ const PictureLayerTiling* twin_tiling);
+ TileBundle* TileBundleAt(int, int) const;
// Given properties.
float contents_scale_;
@@ -202,7 +249,9 @@ class CC_EXPORT PictureLayerTiling {
// Internal data.
TilingData tiling_data_;
- TileMap tiles_; // It is not legal to have a NULL tile in the tiles_ map.
+ TilingData bundle_tiling_data_;
+ TileBundleMap tile_bundles_; // It is not legal to have a NULL tile in the
+ // tiles_ map.
gfx::Rect live_tiles_rect_;
// State saved for computing velocities based upon finite differences.

Powered by Google App Engine
This is Rietveld 408576698