tools/metrics/actions/actions.xml - Issue 622813002: [Manifest] Add metrics recording.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/actions/actions.xml

Issue 622813002: [Manifest] Add metrics recording. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@screen_orientation_usage_count

Patch Set: review comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/metrics/actions/actions.xml

diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml

index acc96a35aa6f9e065539005a13b29b83e8e313fe..b492bc57ff56153451247ec8270ec7091c89a7ca 100644

--- a/tools/metrics/actions/actions.xml

+++ b/tools/metrics/actions/actions.xml

@@ -11599,4 +11599,13 @@ should be able to be added at any place in this file.

<description>Shortcut added to the homescreen for a bookmark.</description>

</action>

+<action name="webapps.AddShortcut.Manifest">

+ <owner>mlamouri@chromium.org</owner>

+ <description>

+ Shortcut added to the homescreen with a valid Manifest. This action will be

+ recorded in addition of AppShortcut, AppShortcutApple and Bookmark actions

Mark P 2014/10/07 16:43:53 nit: of -> to

mlamouri (slow - plz ping) 2014/10/07 17:30:42 Done.

+ above to keep a trend of whether the webapp also add meta tags.

Mark P 2014/10/07 16:43:53 meta tags? I understand this comment in the contex

Mark P 2014/10/07 16:43:53 nit: omit "above" These actions can appear in arb

mlamouri (slow - plz ping) 2014/10/07 17:30:42 Done.

+ </description>

+</action>

</actions>

« no previous file with comments | « content/renderer/manifest/manifest_uma_util.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »