content/renderer/manifest/manifest_uma_util.h - Issue 622813002: [Manifest] Add metrics recording.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/renderer/manifest/manifest_uma_util.h

Issue 622813002: [Manifest] Add metrics recording. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@screen_orientation_usage_count

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/renderer/manifest/manifest_parser.cc ('K') | « content/renderer/manifest/manifest_parser.cc ('k') | content/renderer/manifest/manifest_uma_util.cc » ('j') | content/renderer/manifest/manifest_uma_util.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_RENDERER_MANIFEST_MANIFEST_UMA_UTIL_H_

	6 #define CONTENT_RENDERER_MANIFEST_MANIFEST_UMA_UTIL_H_

	7

	8 namespace content {

	9

	10 struct Manifest;

	11

	12 class ManifestUmaUtil {

	13 public:

	14 static void ParsedManifest(const Manifest& manifest);
	Miguel Garcia 2014/10/02 14:26:47 You probably want to add documentation to what eac You probably want to add documentation to what each of the methods does so they can be understood without having to look at the code that calls them mlamouri (slow - plz ping) 2014/10/02 15:35:06 Done. Show quoted text On 2014/10/02 14:26:47, Miguel Garcia wrote: > You probably want to add documentation to what each of the methods does so they > can be understood without having to look at the code that calls them Done.
	15 static void FetchSucceeded();

	16 static void FetchFailed();

	17 };

	18

	19 } // namespace content

	20

	21 #endif // CONTENT_RENDERER_MANIFEST_MANIFEST_UMA_UTIL_H_

OLD	NEW