content/shell/browser/layout_test/layout_test_notification_manager.h - Issue 622793002: Group the different permission related methods in the content api.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_notification_manager.h

Issue 622793002: Group the different permission related methods in the content api. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix blink tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/permission_type.h ('K') | « content/shell/browser/layout_test/layout_test_content_browser_client.cc ('k') | content/shell/browser/layout_test/layout_test_notification_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_notification_manager.h

diff --git a/content/shell/browser/layout_test/layout_test_notification_manager.h b/content/shell/browser/layout_test/layout_test_notification_manager.h

index b97efa44166ac46b7953797c3c393bed41eeb0d1..42f61b49cc78cbcd2cd7719f29790a454c3218cc 100644

--- a/content/shell/browser/layout_test/layout_test_notification_manager.h

+++ b/content/shell/browser/layout_test/layout_test_notification_manager.h

@@ -26,9 +26,8 @@ class LayoutTestNotificationManager {

const GURL& origin);

// Requests permission for |origin| to display notifications in layout tests.

- void RequestPermission(

- const GURL& origin,

- const base::Callback<void(blink::WebNotificationPermission)>& callback);

+ void RequestPermission(const GURL& origin,

+ const base::Callback<void(bool)>& callback);

// Sets the permission to display notifications for |origin| to |permission|.

void SetPermission(const GURL& origin,