Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1846)

Unified Diff: content/shell/browser/layout_test/layout_test_content_browser_client.cc

Issue 622793002: Group the different permission related methods in the content api. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/layout_test_content_browser_client.cc
diff --git a/content/shell/browser/layout_test/layout_test_content_browser_client.cc b/content/shell/browser/layout_test/layout_test_content_browser_client.cc
index c6b033f612a9738b20416ec2ab799afe4e6f61a6..47228c7e8d3e3914c41545062a51a3f3e5ccf386 100644
--- a/content/shell/browser/layout_test/layout_test_content_browser_client.cc
+++ b/content/shell/browser/layout_test/layout_test_content_browser_client.cc
@@ -12,18 +12,6 @@ namespace {
LayoutTestContentBrowserClient* g_layout_test_browser_client;
-void RequestDesktopNotificationPermissionOnIO(
- const GURL& source_origin,
- RenderFrameHost* render_frame_host,
- const base::Callback<void(blink::WebNotificationPermission)>& callback) {
- LayoutTestNotificationManager* manager =
- LayoutTestContentBrowserClient::Get()->GetLayoutTestNotificationManager();
- if (manager)
- manager->RequestPermission(source_origin, callback);
Peter Beverloo 2014/10/20 17:32:16 Removing this is not OK and will break tests. In
Miguel Garcia 2014/10/21 17:17:12 Fixed now On 2014/10/20 17:32:16, Peter Beverloo
- else
- callback.Run(blink::WebNotificationPermissionAllowed);
-}
-
} // namespace
LayoutTestContentBrowserClient::LayoutTestContentBrowserClient() {
@@ -50,19 +38,6 @@ LayoutTestContentBrowserClient::GetLayoutTestNotificationManager() {
return layout_test_notification_manager_.get();
}
-void LayoutTestContentBrowserClient::RequestDesktopNotificationPermission(
- const GURL& source_origin,
- RenderFrameHost* render_frame_host,
- const base::Callback<void(blink::WebNotificationPermission)>& callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- BrowserThread::PostTask(BrowserThread::IO,
- FROM_HERE,
- base::Bind(&RequestDesktopNotificationPermissionOnIO,
- source_origin,
- render_frame_host,
- callback));
-}
-
blink::WebNotificationPermission
LayoutTestContentBrowserClient::CheckDesktopNotificationPermission(
const GURL& source_url,

Powered by Google App Engine
This is Rietveld 408576698