Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 622783003: Reland ServiceWorkerCache stitching (Closed)

Created:
6 years, 2 months ago by jkarlin
Modified:
6 years, 2 months ago
Reviewers:
michaeln, horo
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland ServiceWorkerCache stitching The old CL needed a rebase before landing. Trying again. Reland of: https://codereview.chromium.org/580063003/ BUG=392621 Committed: https://crrev.com/76c9b5b71b41eadc7176ffd88a8d6c46c804a072 Cr-Commit-Position: refs/heads/master@{#297894}

Patch Set 1 : Original CL that failed to compile on master #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -9 lines) Patch
M content/browser/service_worker/service_worker_cache_listener.h View 3 chunks +18 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_listener.cc View 1 6 chunks +182 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jkarlin
michaeln@chromium.org: Please review changes in all horo@chromium.org: Please review changes in all This is a ...
6 years, 2 months ago (2014-10-02 17:43:00 UTC) #2
michaeln
still lgtm also this class looks pretty unit testable (although it might help to utilize ...
6 years, 2 months ago (2014-10-02 19:37:38 UTC) #3
jkarlin
On 2014/10/02 19:37:38, michaeln wrote: > still lgtm > > also this class looks pretty ...
6 years, 2 months ago (2014-10-02 20:40:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622783003/20001
6 years, 2 months ago (2014-10-02 20:42:04 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 307ad3bde967362c5e14ddf5f65f9501dfd6abfa
6 years, 2 months ago (2014-10-02 20:47:00 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 20:47:33 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/76c9b5b71b41eadc7176ffd88a8d6c46c804a072
Cr-Commit-Position: refs/heads/master@{#297894}

Powered by Google App Engine
This is Rietveld 408576698