Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Issue 622773003: Demote getCount, getDepth, and clear to RTree-only methods. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Demote getCount, getDepth, and clear to RTree-only methods. We use them only to test RTree. BUG=skia: Committed: https://skia.googlesource.com/skia/+/8f8c25eabb97da8eda488895f04f2d12cb5ea4cf

Patch Set 1 #

Total comments: 2

Patch Set 2 : Small diffs. #

Patch Set 3 : update bench #

Patch Set 4 : dox #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -55 lines) Patch
M bench/RTreeBench.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkBBoxHierarchy.h View 1 chunk +0 lines, -17 lines 0 comments Download
M src/core/SkRTree.h View 1 2 3 1 chunk +6 lines, -14 lines 0 comments Download
M src/core/SkTileGrid.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/core/SkTileGrid.cpp View 1 2 chunks +0 lines, -7 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/RecordDrawTest.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
mtklein
6 years, 2 months ago (2014-10-02 15:56:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622773003/1
6 years, 2 months ago (2014-10-02 15:57:16 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-02 15:57:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622773003/20001
6 years, 2 months ago (2014-10-02 16:00:16 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-02 16:00:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622773003/40001
6 years, 2 months ago (2014-10-02 16:01:07 UTC) #10
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-02 16:01:08 UTC) #11
robertphillips
lgtm + dox suggestion https://codereview.chromium.org/622773003/diff/1/src/core/SkRTree.h File src/core/SkRTree.h (right): https://codereview.chromium.org/622773003/diff/1/src/core/SkRTree.h#newcode81 src/core/SkRTree.h:81: keep the comments?
6 years, 2 months ago (2014-10-02 16:07:58 UTC) #13
mtklein
https://codereview.chromium.org/622773003/diff/1/src/core/SkRTree.h File src/core/SkRTree.h (right): https://codereview.chromium.org/622773003/diff/1/src/core/SkRTree.h#newcode81 src/core/SkRTree.h:81: On 2014/10/02 16:07:58, robertphillips wrote: > keep the comments? ...
6 years, 2 months ago (2014-10-02 16:14:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622773003/60001
6 years, 2 months ago (2014-10-02 16:15:37 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 16:53:09 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 8f8c25eabb97da8eda488895f04f2d12cb5ea4cf

Powered by Google App Engine
This is Rietveld 408576698