Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: components/autofill/core/browser/personal_data_manager.h

Issue 622773002: [Autofill] Autofill fails to show suggestions for credit card split across fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unit-tests. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/personal_data_manager.h
diff --git a/components/autofill/core/browser/personal_data_manager.h b/components/autofill/core/browser/personal_data_manager.h
index a539c5f8f2cf553bbb85aed49314fe0c4a8f1f00..4cdf941267b9ee49842b8e653bee4d557e9071cb 100644
--- a/components/autofill/core/browser/personal_data_manager.h
+++ b/components/autofill/core/browser/personal_data_manager.h
@@ -155,13 +155,22 @@ class PersonalDataManager : public KeyedService,
// Gets credit cards that can suggest data for |type|. See
// GetProfileSuggestions for argument descriptions. The variant in each
// GUID pair should be ignored.
- void GetCreditCardSuggestions(
- const AutofillType& type,
- const base::string16& field_contents,
- std::vector<base::string16>* values,
- std::vector<base::string16>* labels,
- std::vector<base::string16>* icons,
- std::vector<GUIDPair>* guid_pairs);
+ void GetCreditCardSuggestions(const AutofillType& type,
+ const base::string16& field_contents,
+ std::vector<base::string16>* values,
+ std::vector<base::string16>* labels,
+ std::vector<base::string16>* icons,
+ std::vector<GUIDPair>* guid_pairs);
+
+ // Appends the |credit_card| details to the suggestions based on the |type|
+ // specified.
+ void AppendCreditCardSuggetions(const CreditCard* credit_card,
+ const AutofillType& type,
+ const base::string16 field_contents,
+ std::vector<base::string16>* values,
+ std::vector<base::string16>* labels,
+ std::vector<base::string16>* icons,
+ std::vector<GUIDPair>* guid_pairs);
// Re-loads profiles and credit cards from the WebDatabase asynchronously.
// In the general case, this is a no-op and will re-create the same

Powered by Google App Engine
This is Rietveld 408576698