components/autofill/core/browser/autofill_manager.h - Issue 622773002: [Autofill] Autofill fails to show suggestions for credit card split across fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.h

Issue 622773002: [Autofill] Autofill fails to show suggestions for credit card split across fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added unit-tests. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_field.cc ('K') | « components/autofill/core/browser/autofill_field.cc ('k') | components/autofill/core/browser/autofill_manager.cc » ('j') | components/autofill/core/browser/autofill_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager.h

diff --git a/components/autofill/core/browser/autofill_manager.h b/components/autofill/core/browser/autofill_manager.h

index 0011cf5efdb4a7c833a1508a82e71522b2c23a29..80dcacdf6808e11fa55398f017955ef14e2edde3 100644

--- a/components/autofill/core/browser/autofill_manager.h

+++ b/components/autofill/core/browser/autofill_manager.h

@@ -274,7 +274,7 @@ class AutofillManager : public AutofillDownloadManager::Observer {

// Returns a list of values from the stored credit cards that match |type| and

// the value of |field| and returns the labels of the matching credit cards.

void GetCreditCardSuggestions(const FormFieldData& field,

- const AutofillType& type,

+ const AutofillField& autofill_field,

std::vector<base::string16>* values,

std::vector<base::string16>* labels,

std::vector<base::string16>* icons,