Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: components/autofill/core/browser/personal_data_manager_unittest.cc

Issue 622773002: [Autofill] Autofill fails to show suggestions for credit card split across fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/personal_data_manager_unittest.cc
diff --git a/components/autofill/core/browser/personal_data_manager_unittest.cc b/components/autofill/core/browser/personal_data_manager_unittest.cc
index 81724d770096a898f8baf4328aaffdba718b398c..942d50ce84fd1d61bf6fd65195d4b9509e22fdba 100644
--- a/components/autofill/core/browser/personal_data_manager_unittest.cc
+++ b/components/autofill/core/browser/personal_data_manager_unittest.cc
@@ -2698,6 +2698,25 @@ TEST_F(PersonalDataManagerTest, GetCreditCardSuggestions) {
EXPECT_EQ(ASCIIToUTF16("04/15"), labels[0]);
EXPECT_EQ(ASCIIToUTF16("********2109"), values[1]);
EXPECT_EQ(base::string16(), labels[1]);
+
+ // Retrieve suggetions without obfuscating the card number.
+ values.clear();
+ labels.clear();
+ icons.clear();
+ guid_pairs.clear();
+ personal_data_->GetCreditCardSuggestions(AutofillType(CREDIT_CARD_NUMBER),
+ base::string16(),
+ &values,
+ &labels,
+ &icons,
+ &guid_pairs,
+ false);
+ ASSERT_EQ(2U, values.size());
+ ASSERT_EQ(values.size(), labels.size());
+ EXPECT_EQ(ASCIIToUTF16("347666888555"), values[0]);
+ EXPECT_EQ(ASCIIToUTF16("04/15"), labels[0]);
+ EXPECT_EQ(ASCIIToUTF16("518765432109"), values[1]);
+ EXPECT_EQ(base::string16(), labels[1]);
}
#if defined(OS_MACOSX) && !defined(OS_IOS)

Powered by Google App Engine
This is Rietveld 408576698