[Autofill] Autofill fails to show suggestions for credit card split across fields.

components/autofill/core/browser/personal_data_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/personal_data_manager.h"
 
 #include <algorithm>
 #include <functional>
 #include <iterator>
 
@@ skipping 649 matching lines @@
 
   const std::vector<CreditCard*>& credit_cards = GetCreditCards();
   for (std::vector<CreditCard*>::const_iterator iter = credit_cards.begin();
        iter != credit_cards.end(); ++iter) {
     CreditCard* credit_card = *iter;
 
     // The value of the stored data for this field type in the |credit_card|.
     base::string16 creditcard_field_value =
         credit_card->GetInfo(type, app_locale_);
     if (!creditcard_field_value.empty() &&
-        StartsWith(creditcard_field_value, field_contents, false)) {
-      if (type.GetStorableType() == CREDIT_CARD_NUMBER)
-        creditcard_field_value = credit_card->ObfuscatedNumber();
-
-      // If the value is the card number, the label is the expiration date.
-      // Otherwise the label is the card number, or if that is empty the
-      // cardholder name. The label should never repeat the value.
-      base::string16 label;
-      if (type.GetStorableType() == CREDIT_CARD_NUMBER) {
-        label = credit_card->GetInfo(
-            AutofillType(CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR), app_locale_);
-      } else if (credit_card->number().empty()) {
-        if (type.GetStorableType() != CREDIT_CARD_NAME) {
-          label =
-              credit_card->GetInfo(AutofillType(CREDIT_CARD_NAME), app_locale_);
-        }
-      } else {
-        label = kCreditCardPrefix;
-        label.append(credit_card->LastFourDigits());
-      }
-
-      values->push_back(creditcard_field_value);
-      labels->push_back(label);
-      icons->push_back(base::UTF8ToUTF16(credit_card->type()));
-      guid_pairs->push_back(GUIDPair(credit_card->guid(), 0));
-    }
+        StartsWith(creditcard_field_value, field_contents, false))
+      AppendCreditCardSuggetions(credit_card,
+                                 type,
+                                 creditcard_field_value,
+                                 values,
+                                 labels,
+                                 icons,
+                                 guid_pairs);
   }
 }
 
 bool PersonalDataManager::IsAutofillEnabled() const {
   DCHECK(pref_service_);
   return pref_service_->GetBoolean(prefs::kAutofillEnabled);
 }
 
 std::string PersonalDataManager::CountryCodeForCurrentTimezone() const {
   return base::CountryCodeForCurrentTimezone();
@@ skipping 403 matching lines @@
 
   // Populates |auxiliary_profiles_|.
   LoadAuxiliaryProfiles(record_metrics);
 
   profiles_.insert(profiles_.end(), web_profiles_.begin(), web_profiles_.end());
   profiles_.insert(
       profiles_.end(), auxiliary_profiles_.begin(), auxiliary_profiles_.end());
   return profiles_;
 }
 
+void PersonalDataManager::AppendCreditCardSuggetions(
+    const CreditCard* credit_card,
+    const AutofillType& type,
+    const base::string16 field_contents,
+    std::vector<base::string16>* values,
+    std::vector<base::string16>* labels,
+    std::vector<base::string16>* icons,
+    std::vector<GUIDPair>* guid_pairs) {
+  if (credit_card->GetInfo(type, app_locale_).empty())
+    return;
+
+  base::string16 user_input = field_contents;
+  if (type.GetStorableType() == CREDIT_CARD_NUMBER)
+    user_input = credit_card->ObfuscatedNumber();
+
+  // If the value is the card number, the label is the expiration date.
+  // Otherwise the label is the card number, or if that is empty the
+  // cardholder name. The label should never repeat the value.
+  base::string16 label;
+  if (type.GetStorableType() == CREDIT_CARD_NUMBER) {
+    label = credit_card->GetInfo(
+        AutofillType(CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR), app_locale_);
+  } else if (credit_card->number().empty()) {
+    if (type.GetStorableType() != CREDIT_CARD_NAME) {
+      label = credit_card->GetInfo(AutofillType(CREDIT_CARD_NAME), app_locale_);
+    }
+  } else {
+    label = kCreditCardPrefix;
+    label.append(credit_card->LastFourDigits());
+  }
+
+  values->push_back(user_input);
+  labels->push_back(label);
+  icons->push_back(base::UTF8ToUTF16(credit_card->type()));
+  guid_pairs->push_back(GUIDPair(credit_card->guid(), 0));
+}
+
 }  // namespace autofill