Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: components/autofill/core/browser/autofill_manager.h

Issue 622773002: [Autofill] Autofill fails to show suggestions for credit card split across fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unit-tests. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 const FormFieldData& field, 267 const FormFieldData& field,
268 const AutofillField& autofill_field, 268 const AutofillField& autofill_field,
269 std::vector<base::string16>* values, 269 std::vector<base::string16>* values,
270 std::vector<base::string16>* labels, 270 std::vector<base::string16>* labels,
271 std::vector<base::string16>* icons, 271 std::vector<base::string16>* icons,
272 std::vector<int>* unique_ids) const; 272 std::vector<int>* unique_ids) const;
273 273
274 // Returns a list of values from the stored credit cards that match |type| and 274 // Returns a list of values from the stored credit cards that match |type| and
275 // the value of |field| and returns the labels of the matching credit cards. 275 // the value of |field| and returns the labels of the matching credit cards.
276 void GetCreditCardSuggestions(const FormFieldData& field, 276 void GetCreditCardSuggestions(const FormFieldData& field,
277 const AutofillType& type, 277 const AutofillField& autofill_field,
278 std::vector<base::string16>* values, 278 std::vector<base::string16>* values,
279 std::vector<base::string16>* labels, 279 std::vector<base::string16>* labels,
280 std::vector<base::string16>* icons, 280 std::vector<base::string16>* icons,
281 std::vector<int>* unique_ids) const; 281 std::vector<int>* unique_ids) const;
282 282
283 // Parses the forms using heuristic matching and querying the Autofill server. 283 // Parses the forms using heuristic matching and querying the Autofill server.
284 void ParseForms(const std::vector<FormData>& forms); 284 void ParseForms(const std::vector<FormData>& forms);
285 285
286 // Imports the form data, submitted by the user, into |personal_data_|. 286 // Imports the form data, submitted by the user, into |personal_data_|.
287 void ImportFormData(const FormStructure& submitted_form); 287 void ImportFormData(const FormStructure& submitted_form);
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 UserHappinessFormLoadAndSubmission); 380 UserHappinessFormLoadAndSubmission);
381 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction); 381 FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction);
382 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 382 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
383 FormSubmittedAutocompleteEnabled); 383 FormSubmittedAutocompleteEnabled);
384 DISALLOW_COPY_AND_ASSIGN(AutofillManager); 384 DISALLOW_COPY_AND_ASSIGN(AutofillManager);
385 }; 385 };
386 386
387 } // namespace autofill 387 } // namespace autofill
388 388
389 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 389 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698