[Autofill] Autofill fails to show suggestions for credit card split across fields.

components/autofill/core/browser/autofill_field.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_field.h"
 
 #include "base/logging.h"
 #include "base/sha1.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
@@ skipping 266 matching lines @@
 // Set |field_data|'s value to |number|, or possibly an appropriate substring of
 // |number|.  The |field| specifies the type of the phone and whether this is a
 // phone prefix or suffix.
 void FillPhoneNumberField(const AutofillField& field,
                           const base::string16& number,
                           FormFieldData* field_data) {
   field_data->value =
       AutofillField::GetPhoneNumberValue(field, number, *field_data);
 }
 
-// Set |field_data|'s value to |number|, or possibly an appropriate substring
-// of |number| for cases where credit card number splits across multiple HTML
-// form input fields.
-// The |field| specifies the |credit_card_number_offset_| to the substring
-// within credit card number.
-void FillCreditCardNumberField(const AutofillField& field,
-                               const base::string16& number,
-                               FormFieldData* field_data) {
-  base::string16 value = number;
-
-  // |field|'s max_length truncates credit card number to fit within.
-  if (field.credit_card_number_offset() < value.length())
-    value = value.substr(field.credit_card_number_offset());
-
-  field_data->value = value;
-}
-
 // Fills in the select control |field| with |value|.  If an exact match is not
 // found, falls back to alternate filling strategies based on the |type|.
 bool FillSelectControl(const AutofillType& type,
                        const base::string16& value,
                        const std::string& app_locale,
                        FormFieldData* field) {
   DCHECK_EQ("select-one", field->form_control_type);
 
   // Guard against corrupted values passed over IPC.
   if (field->option_values.size() != field->option_contents.size())
@@ skipping 171 matching lines @@
     FillPhoneNumberField(field, value, field_data);
     return true;
   } else if (field_data->form_control_type == "select-one") {
     return FillSelectControl(type, value, app_locale, field_data);
   } else if (field_data->form_control_type == "month") {
     return FillMonthControl(value, field_data);
   } else if (type.GetStorableType() == ADDRESS_HOME_STREET_ADDRESS) {
     FillStreetAddress(value, address_language_code, field_data);
     return true;
   } else if (type.GetStorableType() == CREDIT_CARD_NUMBER) {
-    FillCreditCardNumberField(field, value, field_data);
+    field_data->value = AutofillField::GetCreditCardNumberValue(field, value);

[ziran.sun, 2014/10/08 16:25:55]

For consistency it might be worth keeping FillCreditCardNumberField() function,
in which you can call GetCreditCardNumberValue().

[Ilya Sherman, 2014/10/08 21:04:38]

Alternately, you could inline the FillPhoneNumberField implementation.  I agree
that the two should ideally be consistent.

[Pritam Nikam, 2014/10/09 06:11:11]

Done.

     return true;
   }
 
   field_data->value = value;
   return true;
 }
 
 base::string16 AutofillField::GetPhoneNumberValue(
     const AutofillField& field,
     const base::string16& number,
@@ skipping 13 matching lines @@
 
   if (field.phone_part() == AutofillField::PHONE_SUFFIX ||
       field_data.max_length == PhoneNumber::kSuffixLength) {
     return
         number.substr(PhoneNumber::kSuffixOffset, PhoneNumber::kSuffixLength);
   }
 
   return number;
 }
 
+// The |field| specifies the |credit_card_number_offset_| to the substring

[Ilya Sherman, 2014/10/07 21:49:10]

nit: "credit_card_number_offset_" -> "credit_card_number_offset()"

[Pritam Nikam, 2014/10/08 05:17:17]

Done.

+// within credit card number.
+base::string16 AutofillField::GetCreditCardNumberValue(
+    const AutofillField& field,
+    const base::string16& number) {
+  base::string16 value = number;
+
+  // |field|'s max_length truncates credit card number to fit within.
+  if (field.credit_card_number_offset() < value.length())
+    value = value.substr(field.credit_card_number_offset());
+
+  return value;
+}
+
 }  // namespace autofill